Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanupOnStop option does not clean up resources if DevWorkspace Deployment does not exist #922

Closed
amisevsk opened this issue Sep 10, 2022 · 0 comments · Fixed by #1016
Closed
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

When enabling the config.workspace.cleanupOnStop option in the DevWorkspaceOperatorConfig, the setting is ignored when cleaning up workspaces that do not have a deployment. This means that services, configmaps, etc. are potentially left in the namespace for stopped workspaces.

How To Reproduce

  1. Enable cleanupOnStop in the DevWorkspaceOperatorConfig
  2. Create a workspace that fails before the deployment is created (e.g. by using an invalid routingClass -- cluster-tls on a Kubernetes cluster)
  3. When workspace fails, DevWorkspaceRouting is left on cluster

Expected behavior

Cleanup should be processed the same regardless of whether or not Deployment exists.

Additional context

@amisevsk amisevsk mentioned this issue Jan 9, 2023
60 tasks
@ibuziuk ibuziuk added the sprint/current Is assigned to issues which are planned to work on in the current team sprint label Jan 10, 2023
@amisevsk amisevsk self-assigned this Jan 12, 2023
@amisevsk amisevsk added this to the v0.19.x milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants