Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevWorkspace Operator should detect changes to automount volumes/secrets/configmaps and update running workspaces #914

Closed
amisevsk opened this issue Sep 1, 2022 · 0 comments · Fixed by #1017
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Sep 1, 2022

Description

The DevWorkspace Operator processes automount volumes/configmaps/secrets only when reconciling a DevWorkspace. However, since these objects are meant to be shared across workspaces, they are not owned by any one workspace and so editing them does not trigger reconciles.

This means that if e.g. a new automount configmap is added to a namespace, it will only be propagated to DevWorkspaces on the next reconcile (which could be a while if there are no events).

Instead, the DevWorkspace Operator should watch automount resources and trigger reconciles for any running workspaces in their namespace to ensure they are up-to-date.

Additional context

This issue also means that updating/refreshing personal access tokens store in a controller.devfile.io/git-credential secret will not be propagated to the merged credentials secret until any DevWorkspace is reconciled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
2 participants