Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount volumes to all containers by defining it in a DevWorkspaceTemplate #628

Closed
benoitf opened this issue Oct 1, 2021 · 3 comments
Closed
Milestone

Comments

@benoitf
Copy link
Collaborator

benoitf commented Oct 1, 2021

Description

Allow DevWorkspaceTemplate to notify the controller to mount a given volumePath to all containers

Additional context

use-case: As editors could run inside the user containers, there is a need to be able to execute the container from this volume.
But we can't require to have all devfiles adding a volume that they don't know about.

So I would know if I could use some annotations to notify that I want that a volume could be added in all containers.

Note

It would be fine to only mount the volume in the first available container or a container being annotated

@sleshchenko
Copy link
Member

Investigation issue is created #656

@benoitf
Copy link
Collaborator Author

benoitf commented Oct 21, 2021

Also based on the feedback, it could be mounted just on a given container (like the first one having mountSources:true)
And like we can assign a main endpoint, we could assign a 'main' container as well.

@amisevsk
Copy link
Collaborator

Likely superceded by #656 -- please reopen if this is needed independently from the other issue.

@amisevsk amisevsk added this to the v0.15.x milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants