-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ssh keys and tls certs into gitconfig #613
Comments
Hi, a question to the assignee of this issue: Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide? Yes/No? |
SSH support can be enabled by: cat > /tmp/gitconfig <<EOF
host *
IdentityFile /.ssh/id_rsa
StrictHostKeyChecking = no
EOF
kubectl create secret generic git-ssh-key \
--from-file=id_rsa=/path/to/private-key \
--from-file=id_rsa.pub=/path/to/public-key \
--from-file=config=/tmp/gitconfig
kubectl patch secret git-ssh-key --type merge -p \
'{"metadata": {
"labels": {
"controller.devfile.io/mount-to-devworkspace": "true",
"controller.devfile.io/watch-secret": "true"
},
"annotations": {
"controller.devfile.io/mount-path": "/.ssh/"
}
}
}' TLS cert support can be enabled by: apiVersion: v1
kind: ConfigMap
metadata:
name: tls-configmap-test
namespace: devworkspace-controller
labels:
"controller.devfile.io/git-tls-credential": "true"
"controller.devfile.io/watch-configmap": "true"
annotations:
controller.devfile.io/mount-path: /home/theia/tls
data:
host: https://github.com # this is optional, if its not set then the certificate will be applied to all git servers
certificate: asdfasdfasdfasdfasdfasdfasdfasdf # this is the public certificate that you can download through your browser |
@skabashnyuk my understanding that this issue is done from the DevWorkspace perspective, the follow-up work should be part of eclipse-che/che#20832 |
Researching this, I could not find a mention of the |
@metlos it has been merged [1] recently I believe - https://github.com/devfile/devworkspace-operator/blob/main/pkg/constants/metadata.go#L54 [1] #625 |
@ibuziuk is there something left for this issue? |
No, my PR as been merged a bit ago I just forgot to close this issue |
Description
Currently, DWO generates gitconfig with personal access tokens, but it does not propagate SSH keys secrets, nor TLS certs.
The text was updated successfully, but these errors were encountered: