Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWO does not seem to reconcile DevWorkspace after DevWorkspaceTemplate is changed #432

Closed
sleshchenko opened this issue May 21, 2021 · 3 comments
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@sleshchenko
Copy link
Member

DWO does not seem to reconcile DevWorkspace after DevWorkspaceTemplate is changed.
P.S. DevWorkspaceTemplate seems to have the right ownerReference set.

Steps to reproduce:

  1. Run DevWorkspace with Eclipse Che.
  2. Update theia image in DevWorkspaceTemplate of Theia.
    Expected: DevWorkspace deployment is updated with newer image.
    Actual: DevWorkspace deployment uses the old configuration.
@sleshchenko
Copy link
Member Author

Reproduced

@sleshchenko sleshchenko added this to the v0.9.0 milestone Jul 27, 2021
@sleshchenko sleshchenko added sprint/current Is assigned to issues which are planned to work on in the current team sprint and removed sprint/next labels Jul 29, 2021
@JPinkney JPinkney self-assigned this Aug 10, 2021
@amisevsk
Copy link
Collaborator

Expected: DevWorkspace deployment is updated with newer image.

I'd argue that this is a bad idea -- if there are a hundred DevWorkspaces, any update to the Theia DWT would result in >100 reconciles immediately being queued up, and potentially every DevWorkspace on the cluster restarting.

@sleshchenko
Copy link
Member Author

Agreed that we don't won't to support it. We assign ownerRef for DWT being removed after DW is removed, but we don't want DWT updates - invoke reconcile loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

No branches or pull requests

3 participants