Library api improvements

[mmulholla]

My comments after doing a quick review of the api's

• Add, Update Set api's should parse what is provided to make sure it is valid, return an error if not. we do not help validate, only do simple add/update/delete
• Update api's should return an error if the updated object is not already known to the parser Update api's should return an error if the specific element does not exist #448
• Add api's tend to return on first error, rather than process everything provided. For example if I add 5 components 4 will be added if the 5th is a duplicate but only 1 will be added if the 2nd is a duplicate. Library add apis should process everything before return an error #449
• No Delete api's except for Volumes. Delete api's would be useful. Devfile Library Delete Functionality #357
• Why Volumes api's but nothing for Groups, Endpoints etc? (Maysun: Not sure the purpose of an util for Command Groups. Dont think we will add util funcs for Endpoint until a need arises, users can use UpdateComponent)
• Why utils GetDevfileContainerComponents, and GetDevfileVolumeComponents - planning to expand these to be comprehensive for command, projects etc? Deprecated, they are now available via https://github.com/devfile/library/blob/master/pkg/devfile/parser/data/v2/common/options.go
• Difficult to find methods for creating and managing a devfile (Maysun: we already have a writer func func (d *DevfileObj) WriteYamlDevfile() error. ) (Added writer usage example in library readme devfile/library@6c950fe#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5)
• Inconstant parameters required already fixed

Also we need api documentation which provides a list of errors returned.

[dharmit]

No Delete api's except for Volumes. Delete api's would be useful.

+1.

We are looking for DeleteComponent to be able to delete a component from the devfile. The use case for odo is to delete a Kubernetes inlined component from devfile when the user does odo service delete. It's already possible to add a Kubernetes inlined component when doing odo service create since AddComponent method already exists.

odo issue dependent on this is redhat-developer/odo#4160.

[yangcao77]

Closing this issue since it has been completed.