Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema version incompatibility with nodejs-basic sample parent #1590

Closed
1 task done
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Jun 5, 2024

Which area is this issue related to?

/area registry

Issue Description

The nodejs-basic sample should update the schema version to 2.2.2 to match the Node.js Runtime nodejs parent stack which had updated the default schema version in devfile/registry#403.

Acceptance Criteria

  • Update to schema version 2.2.2
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Jun 5, 2024
@michael-valdron michael-valdron moved this to Refinement in Devfile Project Jun 5, 2024
@michael-valdron michael-valdron self-assigned this Jun 5, 2024
@michael-valdron michael-valdron moved this from Refinement to In Review 👀 in Devfile Project Jun 5, 2024
@michael-valdron
Copy link
Member Author

Sized issue based on duration it took me.

Priority set as blocker due to it blocking from promoting community devfile registry staging to production.

@michael-valdron
Copy link
Member Author

Need to change schema version under extraDevfileEntries.yaml as well: devfile/registry#415

@michael-valdron
Copy link
Member Author

Changed approach to referencing the previous parent stack version due to OpenShift Dev Console incompatibility with devfile 2.2.2 spec: devfile/registry#415 (comment)

@michael-valdron michael-valdron changed the title Update schema version of nodejs-basic sample Fix schema version incompatibility with nodejs-basic sample parent Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment