Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Library's k8s dependencies #1308

Closed
2 tasks done
Tracked by #1303
thepetk opened this issue Oct 25, 2023 · 0 comments · Fixed by devfile/library#187
Closed
2 tasks done
Tracked by #1303

Update Library's k8s dependencies #1308

thepetk opened this issue Oct 25, 2023 · 0 comments · Fixed by devfile/library#187
Assignees
@thepetk
Labels
area/library Common devfile library for interacting with devfiles dependencies Pull requests that update a dependency file

Comments

@thepetk
Copy link
Contributor

thepetk commented Oct 25, 2023 •
edited
Loading

Which area/kind this issue is related to?

/area library

Issue Description

As part of #1303 we should check if we can update the direct dependencies of k8s.io/api, k8s.io/apimachinery, k8s.io/apimachinery, k8s.io/apiextensions-apiserver, k8s.io/client-go, k8s.io/pod-security-admission and sigs.k8s.io/controller-runtime. This dependency is using the golang.org/x/[email protected] which should be updated to a newer version.

As inside go.mod we are including the above packages as direct dependencies, we can update them to v0.26.10 (k8s.io) and to v0.14.7 for controller-runtime which update the net version.

Acceptance Criteria

  • The direct dependencies k8s.io/api, k8s.io/apimachinery, k8s.io/apimachinery, k8s.io/apiextensions-apiserver, k8s.io/client-go, k8s.io/pod-security-admission and sigs.k8s.io/controller-runtime should be updated.
  • Use the same versions that HAS uses: v0.26.10 (k8s.io) and v0.14.7 for controller-runtime.
@openshift-ci openshift-ci bot added the area/library Common devfile library for interacting with devfiles label Oct 25, 2023
@thepetk thepetk mentioned this issue Oct 25, 2023
Closed
9 tasks
@thepetk thepetk moved this to Backlog in Devfile Project Oct 25, 2023
@rm3l rm3l added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@thepetk thepetk self-assigned this Nov 6, 2023
@thepetk thepetk moved this from Backlog to In Progress 🚧 in Devfile Project Nov 6, 2023
@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Nov 6, 2023
@thepetk thepetk mentioned this issue Nov 6, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepetk thepetk

Labels
area/library Common devfile library for interacting with devfiles dependencies Pull requests that update a dependency file
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update k8s.io and sigs.k8s.io direct dependencies thepetk/devfile-library
2 participants
@rm3l @thepetk