Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ParseDevfileAndValidate tests #1099

Closed
kim-tsao opened this issue Apr 11, 2023 · 2 comments
Closed

Improve ParseDevfileAndValidate tests #1099

kim-tsao opened this issue Apr 11, 2023 · 2 comments
Assignees
@feloy

Comments

@kim-tsao
Copy link
Contributor

Which area/kind this issue is related to?

/area library

Issue Description

Currently, there's some unit test coverage for this function but it only covers a subset of parser args. We are missing coverage for Path, URL, RegistryURLs, DefaultNamespace, Context and K8sClient.
@kim-tsao kim-tsao mentioned this issue Apr 11, 2023
Closed
@kim-tsao kim-tsao changed the title Improved ParseDevfileAndValidate tests Improve ParseDevfileAndValidate tests Apr 11, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 11, 2023
@kim-tsao kim-tsao removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 20, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Jul 27, 2023
@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project Aug 4, 2023
@feloy feloy moved this from To Do 📝 to In Progress 🚧 in Devfile Project Sep 19, 2023
@feloy feloy mentioned this issue Sep 21, 2023
Merged
5 tasks
@feloy feloy moved this from In Progress 🚧 to In Review 👀 in Devfile Project Sep 21, 2023
@feloy feloy moved this from In Review 👀 to Done ✅ in Devfile Project Sep 25, 2023
@feloy
Copy link
Contributor

feloy commented Sep 25, 2023

Fixed by devfile/library#183

@feloy feloy closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
None yet
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feloy @kim-tsao