Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire storage enabled volumes for the OCI registry #1093

Open
4 tasks
michael-valdron opened this issue Apr 3, 2023 · 7 comments
Open
4 tasks

Retire storage enabled volumes for the OCI registry #1093

michael-valdron opened this issue Apr 3, 2023 · 7 comments
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Apr 3, 2023 •
edited
Loading

Which area/kind this issue is related to?

/area registry

Issue Description

Currently, the registry operator and the registry helm chart support the usage of a storage enabled volume for the OCI registry path to be mounted on. This allowed OCI artifacts to persist across deployments of the registry. These OCI artifacts at this point are created from the source content on the devfile-index (registry server) image, therefore in addition with security challenges with OpenShift it is best that support for this feature is retired.

The registry operator field spec.storage.enabled should be deprecated and the helm chart field persistence.enabled should also be deprecated. The field spec.storage.enabled should be disabled by default in #1092.

Acceptance Criteria

  • spec.storage.enabled should be disabled by default
  • spec.storage.enabled should be marked as deprecated
  • persistence.enabled should be marked as deprecated
  • Update documentation to reflect these changes
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Apr 3, 2023
@michael-valdron michael-valdron mentioned this issue Apr 3, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 3, 2023
@michael-valdron
Copy link
Member Author

This is a future change that is planned to occur, removing the stale status.

@michael-valdron michael-valdron moved this to Backlog in Devfile Project Jul 20, 2023
@michael-valdron michael-valdron removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 20, 2023
@thepetk
Copy link
Contributor

thepetk commented Aug 4, 2023

We might need to add the acceptance criteria for this issue. Putting it on "waiting" for now.

@thepetk thepetk moved this from Backlog to Waiting in Devfile Project Aug 4, 2023
@michael-valdron
Copy link
Member Author

We might need to add the acceptance criteria for this issue. Putting it on "waiting" for now.

This issue description has been updated to include the acceptance criteria items.

@michael-valdron michael-valdron moved this from Waiting to Backlog in Devfile Project Aug 4, 2023
@elsony
Copy link
Contributor

elsony commented Aug 11, 2023

Make sure the doc includes that the doc mentioned will be using emptyDir storage by default.

@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project Aug 11, 2023
@johnmcollier johnmcollier mentioned this issue Aug 28, 2023
Merged
3 tasks
@michael-valdron michael-valdron moved this from To Do 📝 to Backlog in Devfile Project Oct 13, 2023
@jasperchui jasperchui moved this from Backlog to Refinement in Devfile Project Nov 28, 2023
@michael-valdron michael-valdron added the good first issue Good for newcomers label Dec 21, 2023
@Jdubrick Jdubrick moved this from Refinement to Backlog in Devfile Project Jan 4, 2024
@Horiodino
Copy link

Hii , i would like to work on the issue .can refer where to make changes exactly?

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Devfile Project
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elsony @thepetk @michael-valdron @Horiodino