From ca33ef8705cff2045403dd21b19cd41cee8765ae Mon Sep 17 00:00:00 2001 From: JpunktWpunkt Date: Wed, 24 Jan 2024 11:01:18 +0100 Subject: [PATCH 1/2] fix(ui-library): renamed default to neutral --- .../src/components/internal-components/counter/index.stories.ts | 2 +- packages/ui-library/src/globals/constants.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ui-library/src/components/internal-components/counter/index.stories.ts b/packages/ui-library/src/components/internal-components/counter/index.stories.ts index 645812bbf..a6e6314f6 100644 --- a/packages/ui-library/src/components/internal-components/counter/index.stories.ts +++ b/packages/ui-library/src/components/internal-components/counter/index.stories.ts @@ -91,7 +91,7 @@ export const BlrCounter = (params: BlrCounterType) => BlrCounterRenderFunction(p BlrCounter.storyName = 'Counter'; const defaultParams: BlrCounterType = { theme: 'Light', - variant: 'default', + variant: 'neutral', size: 'md', current: 3, max: 100, diff --git a/packages/ui-library/src/globals/constants.ts b/packages/ui-library/src/globals/constants.ts index eda1d210f..9fd3ffb3b 100644 --- a/packages/ui-library/src/globals/constants.ts +++ b/packages/ui-library/src/globals/constants.ts @@ -30,7 +30,7 @@ export const IconPositionVariant = ['leading', 'trailing'] as const; export const ActionVariants = ['primary', 'secondary', 'cta', 'silent', 'destructive', 'encourage'] as const; export const FeedbackVariants = ['default', 'inverted'] as const; export const CaptionVariants = ['hint', 'error'] as const; -export const CounterVariants = ['default', 'warn', 'error'] as const; +export const CounterVariants = ['neutral', 'warn', 'error'] as const; export const DividerVariations = ['vertical', 'horizontal'] as const; export const TabVariants = ['standard', 'fullWidth'] as const; export const TabContentVariants = ['labelOnly', 'iconOnly', 'labelAndIcon'] as const; From 33835b7effb9368f6683131a8cb3d18942c47b4b Mon Sep 17 00:00:00 2001 From: JpunktWpunkt Date: Wed, 24 Jan 2024 11:16:48 +0100 Subject: [PATCH 2/2] fix(ui-library): changed also the others counter default to neutral --- packages/ui-library/src/components/forms/textarea/index.ts | 2 +- .../src/components/internal-components/counter/index.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ui-library/src/components/forms/textarea/index.ts b/packages/ui-library/src/components/forms/textarea/index.ts index 3b773a2c6..a96443c91 100644 --- a/packages/ui-library/src/components/forms/textarea/index.ts +++ b/packages/ui-library/src/components/forms/textarea/index.ts @@ -88,7 +88,7 @@ export class BlrTextarea extends LitElement { } protected determinateCounterVariant(): CounterVariantType { - let counterVariant: CounterVariantType = 'default'; + let counterVariant: CounterVariantType = 'neutral'; if (this.maxLength) { if (this.warningLimitType === 'warningLimitPer' && this.count >= (this.maxLength / 100) * this.warningLimitPer) { diff --git a/packages/ui-library/src/components/internal-components/counter/index.ts b/packages/ui-library/src/components/internal-components/counter/index.ts index b14ee9a89..50e1dfbc9 100644 --- a/packages/ui-library/src/components/internal-components/counter/index.ts +++ b/packages/ui-library/src/components/internal-components/counter/index.ts @@ -11,7 +11,7 @@ import { TAG_NAME } from './renderFunction'; export class BlrCounter extends LitElement { static styles = []; - @property() variant: CounterVariantType = 'default'; + @property() variant: CounterVariantType = 'neutral'; @property() current = 0; @property() max = 0; @property() size?: FormSizesType = 'md';