Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberInput - fix accessibility violations #774

Closed
5 tasks done
Tracked by #813
thrbnhrtmnn opened this issue Jan 12, 2024 · 1 comment
Closed
5 tasks done
Tracked by #813

NumberInput - fix accessibility violations #774

thrbnhrtmnn opened this issue Jan 12, 2024 · 1 comment
Assignees
@remmycat
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers
Milestone
v0.3 (Beta)

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jan 12, 2024 •
edited
Loading

Description / User Story

The following errors and incomplete tests are thrown by the storybook accessibility addon and should be fixed:

  • Violation: Buttons must have discernible text
  • Violation: Form elements must have labels (placeholder="")
  • Violation: Elements must meet minimum color contrast ratio thresholds (theme=dark)

Requirements

Acceptance Criteria

  • All errors and incomplete tests thrown by the accessibility addon are resolved:
    • Violation: Buttons must have discernible text (readonly=false / unit=defined)
    • Violation: Form elements must have labels (placeholder="")
    • Violation: Elements must meet minimum color contrast ratio thresholds (theme=dark & unit=defined)

Background information

  • ...
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Jan 12, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Jan 12, 2024
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Jan 19, 2024
Open
13 tasks
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Release 1.0, Beta Release Jan 19, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Beta Release, Release 1.0, Evaluate Validation in React Feb 8, 2024
@remmycat remmycat self-assigned this Feb 12, 2024
@remmycat remmycat mentioned this issue Feb 14, 2024
Merged
@thrbnhrtmnn
Copy link
Contributor Author

Approved

@thrbnhrtmnn thrbnhrtmnn modified the milestones: LGL Preperation, Release 1.0 Feb 21, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: v1.0, v0.3 (Beta) Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remmycat remmycat

Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers
Projects
None yet
Milestone
v0.3 (Beta)
Development

No branches or pull requests
2 participants
@remmycat @thrbnhrtmnn