Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check existing components (like Select or Tab Bar) and add events where they are missing #353

Closed
1 task
thrbnhrtmnn opened this issue Sep 15, 2023 · 1 comment
Labels
👻 closed::invalid This doesn't seem right ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Sep 15, 2023

Description

This ticket came after implementing #339 , we should look at more components and check if we also need to change them.


Acceptance Criteria

  • For the Tab Bar: The component should emit an event or trigger a callback function whenever the active tab changes, allowing other parts of the application to respond to the switch.

Background information

@thrbnhrtmnn thrbnhrtmnn changed the title Check existing compoennts (like Select or Tab Bar) and add events where they are missing Check existing components (like Select or Tab Bar) and add events where they are missing Sep 19, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Sep 29, 2023
@thrbnhrtmnn
Copy link
Contributor Author

We do not need this anymore

@thrbnhrtmnn thrbnhrtmnn closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers 👻 closed::invalid This doesn't seem right labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 closed::invalid This doesn't seem right ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant