Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Group - fix group caption #1142

Open
1 of 4 tasks
Tracked by #452
thrbnhrtmnn opened this issue Jul 11, 2024 · 0 comments
Open
1 of 4 tasks
Tracked by #452

Radio Group - fix group caption #1142

thrbnhrtmnn opened this issue Jul 11, 2024 · 0 comments
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

Description / User story

The group caption of the radio group currently has an 8px margin to the top in code. According to design this should be a 16px padding instead. It also seems like there are more containers than needed, which we could also improve while fixing the component.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • The group caption container in the radio group has a padding of 16 px to the top
  • Within the group caption container the first caption (either hint or error) does not have a margin of 8px to the top
  • The gap between hint and error is still according to the token in design (SM 4px, MD 5px, LG 6px)

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors
Projects
None yet
Development

No branches or pull requests

1 participant