Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Group, Button Text, Button Icon, Tab Bar - classMap cleanup #1021

Open
1 of 5 tasks
thrbnhrtmnn opened this issue Mar 14, 2024 · 0 comments
Open
1 of 5 tasks
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Mar 14, 2024

Description / User story

Currently we often have multiple classMaps in our components. This should not be necessary and we should be able to reduce the amount of classMaps to 1 for each component. This would improve code quality, readability and maintainability.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • There is only 1 classMap in the Button Group component
  • There is only 1 classMap in the Button Text component
  • There is only 1 classMap in the Button Icon component
  • There is only 1 classMap in the Tab Bar component

Additional information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Button Group, Button Text, Button Icon - classMap cleanup Button Group, Button Text, Button Icon, Tab Bar - classMap cleanup Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Improve Code Quality milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant