Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to make sure the example applications work before merging #1007

Open
1 of 2 tasks
thrbnhrtmnn opened this issue Mar 8, 2024 · 1 comment
Open
1 of 2 tasks
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Milestone

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Mar 8, 2024

Description / User story

We had issues in the example application(s) before, after merging component changes, which we did not cover with our current tests. Therefor we should extend our tests to cover the example application(s) as well. We can also reach the goal with something else than with unit test. One idea is to prevent merging if compiling the example application does not work.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • We implemented a test, that prevents us from merging branches if the example application breaks

Additional information

  • We could do this by changing the example application to typescript and see if compiling it works

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Mar 8, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Add tests to make sure the example applications work Add mechanism to make sure the example applications work Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Add mechanism to make sure the example applications work Add mechanism to make sure the example applications work before merging Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the More Example Applications milestone Mar 15, 2024
@thrbnhrtmnn
Copy link
Contributor Author

This task is now easier to do after #1096 . The only things we need to do now:

  • use typesafe render functions in example application
  • setup mandatory built task in github workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Development

No branches or pull requests

1 participant