Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TilerFactory::tile breakup? #141

Closed
fredliporace opened this issue Nov 6, 2020 · 4 comments · Fixed by #144
Closed

TilerFactory::tile breakup? #141

fredliporace opened this issue Nov 6, 2020 · 4 comments · Fixed by #144

Comments

@fredliporace
Copy link
Contributor

Salut!

I'm working on a custom tiler based on titiler that use tensorflow inference to generate a classification based on a STAC item's assets. Will include a reference to the repo as soon as it is stable.

The custom tiler uses TilerFactory and needs to re-implement the /tiles/* endpoints to return the classification result instead of assets' raster data. So I'm defining a new tile() function for my custom tiler.

Problem is since I also need the /tilejson endpoint and these are registered within tile() I also need to define the /tilejson/* routes in my tile() function, even though the implementation at the base class could be used as they are defined right now. I'm currently simply copying the tile()::tilejson() to my custom tiler.

One way I see to deal with this is to break the tile() function in TileFactory in two. Does that make sense? If yes I can work on a PR.

@vincentsarago
Copy link
Member

hey @fredliporace, this has been annoying me too, I guess my though was, if you don't add the tile() function you don't need the tilejson and wmts endpoints.

That's say I'll be totally open to review a PR that breaks the tile() function into 3 tile(), wmts(), tilejson() 👍

@fredliporace
Copy link
Contributor Author

@vincentsarago great! Will work on that then.

@vincentsarago
Copy link
Member

@fredliporace I just push some big changes in Master, make sure to sync your branch. If you haven't started working on that yet, I could maybe do it tomorrow!

@fredliporace
Copy link
Contributor Author

@vincentsarago working on it right now, alse detected the starlette issue you mentioned. I'll sync and try to submit the PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants