Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .chromeDataDir option to help debugging tests #8

Merged
merged 14 commits into from
Jun 20, 2020

Conversation

dennis-johnson-dev
Copy link
Contributor

This option is useful when running tests in a non-headless Chrome environment. This will allow Chrome to save user preferences between test runs. For example, one thing I often get frustrated with is that Chrome never remembers where I last left the Chrome Dev Tools. With this change, it will be in the same spot upon returning to debug tests. This also applies to other user preferences as well.

I left it as an "opt-in" rather than a default to avoid folks forgetting to add the datadir to their .gitignore file.

I also had trouble installing this package locally. I kept getting a Plugin 'jsx' not found. I'm happy to further test or improve this pr.

Thanks for this awesome tool!

@developit
Copy link
Owner

What version of node + npm are you running? I've been getting the jsx issue thing on travis and could use any additional information.

@dennis-johnson-dev
Copy link
Contributor Author

dennis-johnson-dev commented Jan 24, 2018

Sure, my env info is:

  • node 8.6.0
  • npm 5.3.0

I have also tried:

  • node 9.3.0
  • npm 5.5.1

My guess is that the problem is a dependency shift? I haven't been able to figure out what exactly is missing the plugin either. Could be babel missing the plugin or perhaps the bundler.

Anecdotally, when I npm link microbundle, the problem goes away. 🤔

@dennis-johnson-dev
Copy link
Contributor Author

screen shot 2018-01-24 at 1 04 39 pm

Ok, was able to repro (I think). I npm linked mircobundle and then I placed a null in microbundle here - https://github.com/developit/microbundle/blob/master/src/index.js#L229. Then placed a console.log here - https://github.com/developit/microbundle/blob/master/src/cli.js#L50.

Hope that helps debug.

@developit
Copy link
Owner

Awesome, thanks @songawee that really does help!

developit added a commit to developit/microbundle that referenced this pull request Jan 24, 2018
@developit
Copy link
Owner

The build error should be fixed in the latest microbundle.

@dennis-johnson-dev
Copy link
Contributor Author

dennis-johnson-dev commented Jan 24, 2018

Thanks for your help with this! Maybe we could try deleting the travis cache to see if that pulls in the fixed dep? - https://docs.travis-ci.com/user/caching/#Clearing-Caches. I've had success with that in circleci. ¯_(ツ)_/¯

@developit
Copy link
Owner

Strangely, no caches are listed :/

@developit developit self-requested a review April 18, 2019 20:31
springer12 added a commit to springer12/microbundle that referenced this pull request May 3, 2020
@developit developit merged commit e6f3004 into developit:master Jun 20, 2020
@developit
Copy link
Owner

Released in 2.0.0.

PatrickMcKenzier pushed a commit to PatrickMcKenzier/microbundle that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants