Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu-list): 修复 左侧菜单全部展开后看不到全部菜单 #89 #99

Closed
wants to merge 12 commits into from

Conversation

TTiip
Copy link
Contributor

@TTiip TTiip commented May 3, 2022

Description

修复 左侧菜单全部展开后看不到全部菜单

close #89

What is the purpose of this pull request?

  • Bug fix: 菜单展开以后显示不全 & 不能滚动问题。

@netlify
Copy link

netlify bot commented May 3, 2022

Deploy Preview for vue-hbs-admin ready!

Name Link
🔨 Latest commit e27e39c
🔍 Latest deploy log https://app.netlify.com/sites/vue-hbs-admin/deploys/62721e122803030008949020
😎 Deploy Preview https://deploy-preview-99--vue-hbs-admin.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TTiip TTiip changed the title 修复 左侧菜单全部展开后看不到全部菜单 #89 fix(menu-list): 修复 左侧菜单全部展开后看不到全部菜单 #89 May 4, 2022
.gitignore Outdated
@@ -6,6 +6,7 @@ yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
lerna-debug.log*
yarn.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更建议使用 pnpm


const getMenuClass = computed(() => {
return ['menu-class', 'menu-class--fixed']
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没看明白这个 computed 存在的意义

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是 参照 /src/layouts/default/sidebar/index.vue 的写法。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidebar/index.vue 是想后面做扩展哈哈~

@likui628 likui628 self-requested a review May 4, 2022 07:09

const getMenuClass = computed(() => {
return ['menu-class', 'menu-class--fixed']
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要用computed属性

@Hongbusi Hongbusi closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

左侧菜单全部展开后看不到全部菜单
3 participants