Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle symlinks, support pnpm and monorepo, #89

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat: Handle symlinks, support pnpm and monorepo, #89

merged 2 commits into from
Sep 12, 2023

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Jun 15, 2023

ref: #84

@rxliuli rxliuli mentioned this pull request Jun 15, 2023
@rxliuli
Copy link
Contributor Author

rxliuli commented Jun 16, 2023

@develar Any progress?

pkg/fs/dirname.go Outdated Show resolved Hide resolved
pkg/fs/findParent.go Outdated Show resolved Hide resolved
pkg/fs/pathExists.go Outdated Show resolved Hide resolved
pkg/node-modules/cli_test.go Outdated Show resolved Hide resolved
pkg/node-modules/cli_test.go Outdated Show resolved Hide resolved
pkg/fs/pathExists.go Outdated Show resolved Hide resolved
pkg/fs/findParent.go Outdated Show resolved Hide resolved
@rxliuli
Copy link
Contributor Author

rxliuli commented Jul 2, 2023

@BlackHole1 Is there anything blocking it now?

@psd-coder
Copy link

Hey guys! Any progress with this PR?

@rxliuli
Copy link
Contributor Author

rxliuli commented Aug 4, 2023

@BlackHole1 any progress?

@BlackHole1
Copy link
Contributor

BlackHole1 commented Aug 24, 2023

Hi @rxliuli. I don’t have the authority to merge this PR, I can only assist with code review. I tried contacting @develar before, but it was unsuccessful.

@miaulightouch
Copy link

miaulightouch commented Sep 12, 2023

Thank you for merging this pull request. I hope there will be a new release soon.

@mmaietta
Copy link
Collaborator

mmaietta commented Feb 14, 2024

Are tests working for anyone? I run app-builder/pkg/node-modules> go test and I receive

--- FAIL: TestNodeDepTreeCmd (0.61s)
    cli_test.go:41: 
        Expected
            <[]string | len:0, cap:0>: []
        to consist of
            <[]interface {} | len:1, cap:1>: [
                ["react", "js-tokens", "loose-envify"],
            ]
--- FAIL: TestReadDependencyTreeByNpm (0.00s)
    nodeModuleCollector_test.go:31: 
        Expected
            <[]string | len:0, cap:0>: []
        to consist of
            <[]interface {} | len:1, cap:1>: [
                ["js-tokens", "react", "loose-envify"],
            ]
--- FAIL: TestReadDependencyTreeByPnpm (0.00s)
    nodeModuleCollector_test.go:56: 
        Expected
            <[]string | len:0, cap:0>: []
        to consist of
            <[]interface {} | len:1, cap:1>: [
                ["js-tokens", "react", "loose-envify"],
            ]
FAIL
exit status 1
FAIL	github.com/develar/app-builder/pkg/node-modules	0.618s

Forked this repo and added a test.yaml since this repo is missing Github Actions for verifying commits and it confirms they're broken
https://github.com/mmaietta/app-builder/actions/runs/7896149587/job/21549639909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants