fix(snap): remove incorrect usage of --target-arch for snapcraft #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapcraft has ignored the target-arch flag, which works in very limited circumstances, with destructive mode. Snapcraft considers it unsupported and will not be fixed in its current form. Recently snapcraft regarded improper usage of this as a hard error instead of silently ignoring, which broke users of app-builder. We reverted that to simply warn, but this fix is to remove its usage from app-builder. If the user is targeting an arch that is not the host arch, error out with a nice message. However, it does require that --arch with `snap` must use the scheme provided by go. If there are a set of supported architecture options somewhere, I can update to ensure that they map to GOARCH. Closes: develar#40 Signed-off-by: Chris Patterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapcraft has ignored the target-arch flag, which works in very
limited circumstances, with destructive mode. Snapcraft considers
it unsupported and will not be fixed in its current form.
Recently snapcraft regarded improper usage of this as a hard error
instead of silently ignoring, which broke users of app-builder. We
reverted that to simply warn, but this fix is to remove its usage
from app-builder.
If the user is targeting an arch that is not the host arch,
error out with a nice message.
However, it does require that --arch with
snapmust use thescheme provided by go. If there are a set of supported architecture
options somewhere, I can update to ensure that they map to GOARCH.
Closes: #40
Signed-off-by: Chris Patterson [email protected]