Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing HTTP proxy support #185

Closed
cailloumajor opened this issue Sep 20, 2022 · 4 comments
Closed

Missing HTTP proxy support #185

cailloumajor opened this issue Sep 20, 2022 · 4 comments
Assignees
@chrmarti
Labels
feature-request New feature or request

Comments

@cailloumajor
Copy link

Hello,

The CLI is not able to do HTTP(S) requests through a proxy. This seems to be inherent to Node.js not supporting proxies (see nodejs/node#8381).
However, solutions seem to exist, e.g. https://www.npmjs.com/package/global-agent.

I would be happy to submit a PR if you want me to.
@chrmarti
Copy link
Contributor

A PR would be appreciated, thanks!

@chrmarti chrmarti self-assigned this Sep 23, 2022
@chrmarti chrmarti added the feature-request New feature or request label Sep 23, 2022
@cailloumajor
Copy link
Author

cailloumajor commented Sep 23, 2022 •
edited
Loading

After looking around, I think https://github.com/npm/make-fetch-happen library would fit very well in place of actually used https://github.com/follow-redirects/follow-redirects, with included HTTP proxy handling in bonus.
@chrmarti if you are okay with that, I will start working on the PR.

@cailloumajor cailloumajor mentioned this issue Sep 23, 2022
Closed
@chrmarti chrmarti mentioned this issue Oct 6, 2022
Closed
@cailloumajor
Copy link
Author

PR #189 is on the way, it is waiting for an approval to run a workflow.

@cailloumajor
Copy link
Author

Fixed with #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrmarti chrmarti

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use make-fetch-happen instead of follow-redirects
2 participants
@cailloumajor @chrmarti