forked from osm-fr/osmose-backend
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Structural_DuplicateNodes.py
100 lines (83 loc) · 4.25 KB
/
Structural_DuplicateNodes.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
#-*- coding: utf-8 -*-
###########################################################################
## ##
## Copyrights Etienne Chové <[email protected]> 2009 ##
## ##
## This program is free software: you can redistribute it and/or modify ##
## it under the terms of the GNU General Public License as published by ##
## the Free Software Foundation, either version 3 of the License, or ##
## (at your option) any later version. ##
## ##
## This program is distributed in the hope that it will be useful, ##
## but WITHOUT ANY WARRANTY; without even the implied warranty of ##
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ##
## GNU General Public License for more details. ##
## ##
## You should have received a copy of the GNU General Public License ##
## along with this program. If not, see <http://www.gnu.org/licenses/>. ##
## ##
###########################################################################
from plugins.Plugin import Plugin
# Largely inspired from
# https://github.com/keepright/keepright/blob/master/checks/0210_loopings.php
class Structural_DuplicateNodes(Plugin):
def init(self, logger):
Plugin.init(self, logger)
self.errors[103] = self.def_class(item = 1010, level = 2, tags = ['geom', 'fix:chair'],
title = T_('Duplicated nodes'),
detail = T_(
'''A path passes several times by the same node.'''),
fix = T_(
'''There are several types of issues:
* A way that makes one or more loops; the way must be split into several
sections.
* A path that goes back on itself (often at one end); the path must be
cut to isolate the wrong section and recreated properly afterwards.
There are certainly many other cases. In general, it is better to make
several roads / areas than a single complex one so that tools working
with OSM data can function properly.'''),
trap = T_(
'''These errors require a good command of your editing tool. Some
corrections are not necessarily intuitive.'''),
example = T_(
'''
Double polygon connected by a string to remove.'''))
def way(self, data, tags, nds):
c = {}
twice = 0
max_ = 0
for n in nds:
c[n] = c.get(n, 0) + 1
max_ = max(max_, c[n])
if c[n] == 2:
twice += 1
# Any way with only 2 different nodes in it, having one node more than once, is an error.
if len(c) == 1:
return {"class": 103, "subclass": 0}
# Any way with only 2 different nodes in it, having one node more than once, is an error.
if len(c) == 2 and max_ > 1:
return {"class": 103, "subclass": 1}
# Way that contains any single node more than twice is considered as an issue
if max_ > 2:
return {"class": 103, "subclass": 2}
###########################################################################
from plugins.Plugin import TestPluginCommon
class Test(TestPluginCommon):
def test(self):
a = Structural_DuplicateNodes(None)
a.init(None)
for nds in [[1, 2],
[2, 4, 189, 100909, 3898932],
[2^32, 4, 189, 100909, 3898932, 0, 2^32-1],
[2**32, 2**32, 0, 0, 2**60, 2**60],
[1, 2, 1, 3, 4, 5, 4],
]:
assert not a.way(None, {}, nds), nds
for nds in [[1, 2, 1, 1, 2], # subclass 2
[2, 4, 189, 100909, 3898932, 100909, 189, 189], # subclass 2
[2**32, 4, 4, 4, 4, 4, 4, 189, 100909, 3898932, 0, 2**32-1], # subclass 2
[1, 2, 1, 1], # subclass 2
[1, 1, 1], # subclass 1
[1, 1], # subclass 0
]:
self.check_err(a.way(None, {}, nds), nds)