Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESIVAST VAC Review (DR1) #9

Open
2 of 4 tasks
dylanagreen opened this issue Nov 29, 2023 · 1 comment
Open
2 of 4 tasks

DESIVAST VAC Review (DR1) #9

dylanagreen opened this issue Nov 29, 2023 · 1 comment
Assignees

Comments

@dylanagreen
Copy link

Draft directory: /global/cfs/cdirs/desi/users/hrincon/DESIVAST_V1
24 catalog files, 25 total

Initial Checks:

  • Includes README
  • Columns in ALLCAPS
  • Extension names in ALLCAPS
  • Files include units

Initial Notes:

  • Your FITS files don't have EXTNAMEs, could you please add some to make it easier to access the table by EXTNAME instead of indices?
  • Generally we request that FITS files include column units. You do have the units documented in the README, would it be possible to also propagate those to the fits files themselves?
  • Can you draft a short (~1-2 paragraph) summary of the VAC to include in the DR1 paper? For an example of what this would look like you can look at section 3.3.6 of the EDR paper (https://arxiv.org/abs/2306.06308).
@dylanagreen dylanagreen self-assigned this Nov 29, 2023
@hbrincon
Copy link

hbrincon commented Dec 4, 2023

@dylanagreen Revisions are located in /global/cfs/cdirs/desi/users/hrincon/DESIVAST_V2

The files should now have EXTNAMES and column units. A draft for the one paragraph VAC summary is located in global/cfs/cdirs/desi/users/hrincon/DESIVAST_V2/VAC_description.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants