Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderators #961

Closed
3 tasks done
julianlam opened this issue Feb 7, 2014 · 14 comments
Closed
3 tasks done

Moderators #961

julianlam opened this issue Feb 7, 2014 · 14 comments
Assignees
Milestone

Comments

@julianlam
Copy link
Member

... because you people keep asking for it! 👿


  • Refactor backend to use user groups
  • Front end admin panel integration
  • isModerator check to categoryTools.privileges and threadTools.privileges
@julianlam julianlam self-assigned this Feb 7, 2014
@julianlam
Copy link
Member Author

@akhoury This is a breaking change for the importer.

Moderators will no longer be placed into the cid:{cid}:moderators set, but are instead added to a user group with the name cid:{cid}:moderators. Do not create this group by hand, just call Groups.joinByGroupName. If it doesn't exist, it will be created and automatically become a system group, which it should be.

@cnvo
Copy link
Contributor

cnvo commented Feb 7, 2014

Woooooooot. :]

On Fri, Feb 7, 2014 at 11:01 AM, Julian Lam [email protected]:

@akhoury https://github.com/akhoury This is a breaking change for the
importer.

Moderators will no longer be placed into the cid:{cid}:moderators set,
but are instead added to a user group with the name cid:{cid}:moderators. Do
not create this group by hand
, just call Groups.joinByGroupName. If it
doesn't exist, it will be created and automatically become a system group,
which it shoud be.


Reply to this email directly or view it on GitHubhttps://github.com//issues/961#issuecomment-34456642
.

julianlam added a commit that referenced this issue Feb 7, 2014
@julianlam
Copy link
Member Author

Changing the group name to be cid:{cid}:privileges:mod

julianlam added a commit that referenced this issue Feb 7, 2014
…would cause the active users box to derp out. Also renamed the moderators priv group name
@akhoury
Copy link
Member

akhoury commented Feb 7, 2014

Acknowledged. Sweet.

@RayBenefield
Copy link

Woohoo! Thanks a ton.

@julianlam
Copy link
Member Author

You can now assign moderators via the "Access Control" modal in the categories section. Please let me know if you run into any bugs.

@nicekiwi
Copy link

nicekiwi commented Mar 2, 2014

screen shot 2014-03-03 at 12 28 57 am

this could be an issue.

@julianlam
Copy link
Member Author

Whoa... How'd you get this to show up?
On Mar 2, 2014 6:29 AM, "Ezra Sharp" [email protected] wrote:

[image: screen shot 2014-03-03 at 12 28 57 am]https://f.cloud.github.com/assets/738975/2304034/e6379a72-a1fd-11e3-89b1-516b3349867b.png

this could be an issue.


Reply to this email directly or view it on GitHubhttps://github.com//issues/961#issuecomment-36451804
.

@nicekiwi
Copy link

nicekiwi commented Mar 3, 2014

I created a single test user, then toggled all options. First Moderator, then Write, then Read and then untoggled them.

Also if I added 'user' to the string in the search field it it adds duplicated of that user.

Content seems to only be appending, not replacing.

@anthonywebb
Copy link
Contributor

Trying to figure out how I can see this new "moderator" button on the category permissions modal. I only show Read and Write, can someone help?

@anthonywebb
Copy link
Contributor

@julianlam is there a secret to enabling category moderators? I only show Read/Write buttons.

@julianlam
Copy link
Member Author

Hey @anthonywebb, sorry about the delay -- what version of NodeBB are you running? Perhaps you have not updated to the latest yet?

git rev-parse HEAD to determine git hash

@julianlam
Copy link
Member Author

Should look a little something like this:

selection_001

Only for users, not groups.

@anthonywebb
Copy link
Contributor

@julianlam ah, users only, found it. I was using groups. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants