Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No widgets showing up when not logged in... #1304

Closed
RayBenefield opened this issue Mar 30, 2014 · 17 comments
Closed

No widgets showing up when not logged in... #1304

RayBenefield opened this issue Mar 30, 2014 · 17 comments
Labels
Milestone

Comments

@RayBenefield
Copy link

So I have widgets setup on the home page, specifically an MOTD, Active Users, and a Shoutbox, however when not logged in none of the widgets show up (might be expected behavior for the shoutbox). In addition to that the category area does not span to fill the screen when those widgets aren't there (which is strange because it has the needed no-widget-class attribute and I thought I saw it was fixed previously). I can't login right now, but I've got a screenshot of what it used to be when logged in.

Not logged in (4161f13):
screenshot 2014-03-30 05 49 26

Logged in (some older version from several weeks ago):
screenshot 2014-03-16 13 57 06

Side Note I just realized: The active users widget probably doesn't act as an online users widget on the home page... so ignore that. lol...

@julianlam
Copy link
Member

Odd, I don't seem to see a nodebb.min.js in the header of your NodeBB. Are you sure vanilla is up to date, or if you're using a custom theme (which it looks like you are), please pull the latest changes from vanilla into your theme.

@RayBenefield
Copy link
Author

I was running a hacked up version of https://github.com/Toolito/nodebb-theme-blacknred mainly because it had a lot of things that needed fixed to work. I just saw that @Toolito updated it recently and updated to that version. Most of that is custom CSS.

Thanks for that... with that out of the way. The widgets are still not loading for not logged in users and the main category area is still not stretching. Not sure if this is a theme thing that will need to be taken care of by @Toolito or if it is a core issue.

http://sandbox.aggrotactics.com/

@preeefix
Copy link
Contributor

It seems that somthing is wrong with nodebb.min.js when it tries to requestPermissions. I compared it to The NodeBB Forums and found that it errored 6 more times with the same error than the official forum... Just throwing that out there.

@RayBenefield
Copy link
Author

Might I ask where you are getting this info? I'm wondering if that is related to AWS's security groups in anyway. Thanks for the heads up @iamcardinal. Web dev is all still very new to me. lol...

@julianlam
Copy link
Member

@GodlyPerfection Looks better now -- the forum no longer loads every page as a new page load.

The blacknred theme might have been forked from Lavender very early on, and it may not have pulled the changes from Lavender to react properly to widget resizing, so @Toolito may have to pull the latest changes in 😄

@preeefix
Copy link
Contributor

I'm stealing his theme xD Looks nice 🐱

@RayBenefield
Copy link
Author

So I'm in the process of replacing my theme with Lavender and working nothing but custom CSS. I'm seeing some weird issues here and there. The widget thing still seems to be a problem, and an issue with the previous theme having a breadcrumb in Unread/Recent/Popular as well as a breadcrumb in the partial topics_list seems to have persisted despite me uninstalling the theme. I can't seem to find the trace of it. AHHH!!!

@preeefix
Copy link
Contributor

Have you removed the nodebb-theme folder?

@RayBenefield
Copy link
Author

Yep... no idea where this is coming from.
screenshot 2014-03-30 13 30 24

@preeefix
Copy link
Contributor

Try removing the nodebb-theme-lavender folder and redownloading it with npm install nodebb-theme-lavender

@RayBenefield
Copy link
Author

Just found out that it is my computer caching it somewhere. :| Despite a hard refresh. My wife's computer doesn't show that. But yeah the widget stuff is still there on my wife's computer.

@preeefix
Copy link
Contributor

@RayBenefield
Copy link
Author

Forgot to close this out. Now that I've switched down to Lavender, I no longer have the custom theme excuse. ;) Good to go. And thanks for that link @crdnl. ;) CTRL-F5 has failed me once more.

Will look into rolling our own custom theme soon. ;) The only part I'm worried about is keeping up to date with the stuff that needs to get updated on the pages that I do change.

@preeefix
Copy link
Contributor

preeefix commented Apr 2, 2014

@GodlyPerfection If you need to keep track with updates, follow the designcreateplay/nodebb-theme-lavender on GitHub and just insert code where needed.

@julianlam
Copy link
Member

@crdnl @GodlyPerfection If you'd like to, you can also use git to handle it. If you forked your theme from lavender, you can do the following:

$ git remote add upstream [email protected]:designcreateplay/nodebb-theme-lavender.git

Then, if you want to merge changes from the upstream (which I've conveniently named upstream):

$ git fetch
$ git merge upstream/master

... and then resolve any conflicts as necessary.

@preeefix
Copy link
Contributor

preeefix commented Apr 2, 2014

ehhh, git...

@RayBenefield
Copy link
Author

Thanks @julianlam, sounds like something that can be done. ;)

@psychobunny psychobunny added this to the 0.4.1 milestone Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants