From f95cc4d327801da1482f37da5c03c1b9cf0fcb0b Mon Sep 17 00:00:00 2001 From: Drew Powers Date: Tue, 20 Aug 2024 08:13:22 -0600 Subject: [PATCH] PR Feedback --- technical-reports/format/composite-types.md | 7 +++++-- technical-reports/format/types.md | 9 ++++----- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/technical-reports/format/composite-types.md b/technical-reports/format/composite-types.md index 3ba5d0e..8b0a1d3 100644 --- a/technical-reports/format/composite-types.md +++ b/technical-reports/format/composite-types.md @@ -236,7 +236,10 @@ Represents a border style. The `$type` property MUST be set to the string `borde "unit": "px" }, "style": { - "dashArray": [{ "value": 0.5, "unit": "rem" }, "0.25rem"], + "dashArray": [ + { "value": 0.5, "unit": "rem" }, + { "value": 0.25, "unit": "rem" } + ], "lineCap": "round" } } @@ -268,7 +271,7 @@ Represents a animated transition between two states. The `$type` property MUST b "$type": "transition", "$value": { "duration": { "value": 200, "unit": "ms" }, - "delay": { "value": 0 }, + "delay": { "value": 0, "unit": "ms" }, "timingFunction": [0.5, 0, 1, 1] } } diff --git a/technical-reports/format/types.md b/technical-reports/format/types.md index 1a1b23a..edbf0e3 100644 --- a/technical-reports/format/types.md +++ b/technical-reports/format/types.md @@ -174,15 +174,15 @@ For example: ```json { - "Duration-100": { + "Duration-Quick": { "$value": { "value": 100, "unit": "ms" }, "$type": "duration" }, - "Duration-200": { - "$value": { "value": 200 }, + "Duration-Long": { + "$value": { "value": 1.5, "unit": "s" }, "$type": "duration" } } @@ -192,8 +192,7 @@ For example: ### Validation -- `$value.unit` may only be `"ms"`, `"s"`, or omitted (`"ms"`) -- `$value.unit`, if omitted, is parsed as if it’s `"ms"` +- `$value.unit` may only be `"ms"` or `"s"` ## Cubic Bézier