From c62ffe3302deb7eeff217929bf7359a24e061ab4 Mon Sep 17 00:00:00 2001 From: Divyansh Choudhary Date: Tue, 16 Jan 2024 13:50:44 +0530 Subject: [PATCH] Fix pre run cell event with ipython 8.18.x (#2) * Fix pre run cell event with ipython 8.18.x * Bump to version 2.0.1 * Fix lint: * Add release date --------- Co-authored-by: Divyansh Choudhary --- CHANGELOG.md | 12 ++++++++++++ jupyterlab_notify/magics.py | 2 +- package.json | 2 +- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d21521b..a3614fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,15 @@ +## [2.0.1](https://github.com/deshaw/jupyterlab-notify/compare/v2.0.1...v2.0.0) (2024-01-16) + +## Fixed + +- Fix the pre run cell hook to be compatible with ipython 8.18.x+ + +## [2.0.0](https://github.com/deshaw/jupyterlab-notify/compare/v2.0.0...v1.0.0) (2023-05-17) + +## Changed + +- Upgrade to jupyterlab4 + ## [1.0.0](https://github.com/deshaw/jupyterlab-notify/compare/v1.0.0...v1.0.0) (2021-07-12) ### Added diff --git a/jupyterlab_notify/magics.py b/jupyterlab_notify/magics.py index f6c6291..d57957b 100644 --- a/jupyterlab_notify/magics.py +++ b/jupyterlab_notify/magics.py @@ -212,7 +212,7 @@ def notify_all(self, line): if self._post_run_cell not in ip.events.callbacks["post_run_cell"]: ip.events.register("post_run_cell", self._post_run_cell) - def _pre_run_cell(self): + def _pre_run_cell(self, info): self.run_start_time = time.time() def _post_run_cell(self, exec_result): diff --git a/package.json b/package.json index 7e7168f..43b9672 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "jupyterlab-notify", - "version": "2.0.0", + "version": "2.0.1", "description": "JupyterLab extension to notify cell completion", "keywords": [ "jupyter",