Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages and logging #1

Open
gczuczy opened this issue May 13, 2015 · 0 comments
Open

Add error messages and logging #1

gczuczy opened this issue May 13, 2015 · 0 comments

Comments

@gczuczy
Copy link

gczuczy commented May 13, 2015

Hello,

Flask uses heavy use of python's logging module, probably would be a good idea to also use it in flask-kerberos.

The _gssapi_authenticate call is completely swallowing diagnostic messages. When something is not working, all we're getting is a 401/403, without any traces or what the hack is going on. The kerberos.GSSError exception contains quite a bit of useful information, which is not being used, but swallowed by a None return. Also, when the nit is failing or anything is happening, there should be logging statements all around the place, with ERROR/WARN levels.

Please improve the library with proper error message propagation. Make it sysadmin friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant