Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when element has right or bottom set #39

Open
desandro opened this issue Oct 15, 2013 · 8 comments
Open

Breaks when element has right or bottom set #39

desandro opened this issue Oct 15, 2013 · 8 comments
Labels

Comments

@desandro
Copy link
Owner

desandro commented Oct 15, 2013

Add a πŸ‘ reaction to this issue if you ran into this issue and would like to see it fixed. Do not add +1 comments β€” They will be deleted.

@robwierzbowski
Copy link

Could you use CSS transforms instead of positioning?

@mr-mig
Copy link

mr-mig commented Sep 5, 2014

I vote for translate support as well.
It is more performant on those browsers, which has the CSS3 transformations support.
And will solve this issue (in the scope, limited by "good" browsers)

@desandro
Copy link
Owner Author

desandro commented Sep 9, 2014

FYI Transforms are used for positioning while dragging. In my experience with Masonry and Isotope, using transforms for static (non-moving) position added a bunch of problems -- font rendering, Flash content broken, breaking other plugins and UI like dropdowns.

@mr-mig
Copy link

mr-mig commented Sep 9, 2014

@desandro really, I should have looked in the sources before raising the voice.

Need to check my use case thoroughly, cause I have the top-left based positioning in Chrome.

Thx for pointing this out.

@mr-mig
Copy link

mr-mig commented Sep 18, 2014

@desandro I still have a question: is there a reason to mix top and left with translate positioning?
I have an issue with those styles mixed - after the drag the setLeftTop method overrides left and top based on the translation coords and remove the translate

@desandro desandro changed the title Breaks when element has right or top set Breaks when element has right or bottom set Sep 19, 2014
@desandro
Copy link
Owner Author

@mr-mig Sounds like a separate implementation issue you're running into, not quite related to the original issue about right or bottom being set. But to your question - yes, I use both top/left and translate values. translate when moving, and then reseting it with top/left. If you're trying to read these values, I suggest looking for the dragPoint property in the source and using that. Or try hooking on the dragMove event.

@mr-mig
Copy link

mr-mig commented Sep 19, 2014

@desandro yeah, I have found it and patched in my fork. Still, I am more interested in the design decision: why those props are not separated?
I have found that Firefox deals really crappy with translate css3 animation, btw. Is it one of the arguments for topLeft positioning?

@franciscolourenco
Copy link

Would be useful to have an option which would toggle between top/left and transform positioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants