Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image selection might be lost by accident without notice #58

Open
derselbst opened this issue Dec 29, 2023 · 0 comments
Open

Image selection might be lost by accident without notice #58

derselbst opened this issue Dec 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@derselbst
Copy link
Owner

derselbst commented Dec 29, 2023

Suppose the user opens a single image and swipes through other images in that directory while selecting images. Move, hardlink or delete operations are only affecting the image currently displayed. Hence, if the user hits ESC for switching over to thumbnail view, the ImageSectionDataContainer with all the selected images will be destroyed and the selection is lost without notice.

Two problems must be addressed:

a) Notification of loss of selection must be done in DocumentView as well.
b) If somehow must be possible to apply a file operation to all the checked files from the DocumentView.

Possible solutions for b):

  1. The ImageSectionDataContainer of the currently active DocumentView with all its images should initialize the model of the ThumbnailView.

Pro: loading times in large directories can be reduced.
Con: Sorting of that DataContainer will not match the previously saved sorting of the ThumbnailViewer model and must be either overriden or expensively re-sorted.

  1. Change the DocumentView to apply FileOperations to all selected images

Pro: Easy to implement
Con: Unintuitive, there might be non-visible side-effects as the user doesn't see which images were selected.

  1. Disable selecting images in DocumentView if DataSectionContainer mismatches the DataContainer of the Model.

Pro: Intuitive
Con: Hard to implement, considering changing directories, closing and reopening of the ThumbnailView window, etc.

@derselbst derselbst added the bug Something isn't working label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant