Fix Geckodriver download issues on Mac #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v6.12.0 of package "laravel/dusk", it changed the return values public method `Laravel\Dusk\OperatingSystem::id()` when running in a Mac environment. It will now _sometimes_ include the architecture in the string. This caused this package's `dusk:firefox-driver` command to skip the operating system configuration. Remove the dependency on `OperatingSystem::id()` as Geckodriver doesn't (yet) have a distributed ARM binary.
When decompressing the Geckodriver .tar.gz to
the local filesystem, suppress stderr output to
the console. Instead capture it for delayed
output in the thrown RuntimeException.
This indirectly also seems to fix extracting
binaries on Mac and Windows (native). The string
"x geckodriver" is being printed to the Mac Terminal
& Windows Command Prompt when PHP's exec('tar -v...')
is called. But the $output array is empty despite
the tarball including a file and tar's verbose is on.
From (probably untrustworthy) php.net user posts, it
may be caused by a newline character being printed on
the terminal before the handled filename "x geckodriver"
is output.
Unrelated: call Laravel's ProcessUtils::escapeArgument()
instead of PHP standard library's escapeshellarg()
because apparently the latter has buggy edge cases.
derekmd
added a commit
that referenced
this pull request
Apr 14, 2021
So much for the comments in #11 as Geckodriver soon after added an ARM binary download. It still doesn't offer an Intel-specific binary so Laravel Dusk's OperatingSystem::id() method still requires a userland (packageland?) replacement to exclude OS detection for 'mac-intel'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7 #8
The
dusk:firefox-drivercommand is showing two issues on Mac:Fix Geckodriver download using Laravel Dusk 6.12.0+
Laravel packages outside "laravel/framework" have a looser interpretation of semvar. [6.x] Add support for Mac ARM64 architecture laravel/dusk#876 changed the return values by public method
Laravel\Dusk\OperatingSystem::id()when running in a Mac environment. It will now sometimes include the architecture in the string. That caused this package'sdusk:firefox-drivercommand to skip the'mac'operating system configuration.Remove the dependency on
OperatingSystem::id()as Geckodriver doesn't (yet) have a distributed ARM binary.Fix the command on Mac failing to capture the extracted filename from the downloaded .tar.gz file. PHP's
exec()doesn't populate its$outputarray argument when run:Appending
2>&1to the command seems to cause thex geckodriveroutput string to be captured in$outputso there are somestdoutpipe shenanigans afoot. Linux terminals and Mingw-w64 on Windows don't have this behavior.