Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Link Hover Color in Light Mode #886

Closed
tbusillo opened this issue Feb 9, 2023 · 1 comment · Fixed by #890
Closed

Change Link Hover Color in Light Mode #886

tbusillo opened this issue Feb 9, 2023 · 1 comment · Fixed by #890
Assignees
@tbusillo

Comments

@tbusillo
Copy link
Contributor

tbusillo commented Feb 9, 2023

Summary

  • Change the Link component's default hover styling in order to improve contrast when it is used on light dark backgrounds.
  • Solution: Replace --link-text-color-hover use of var(--accent-primary) with a new variable using #3873A3.

see:

cauldron/packages/styles/link.css

Line 3 in 4bf529a

--link-text-color-hover: var(--accent-primary);

@tbusillo tbusillo self-assigned this Feb 9, 2023
@tbusillo tbusillo mentioned this issue Feb 14, 2023
Merged
@Keerthi-Penukonda
Copy link

This issue is fixed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbusillo tbusillo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styles): improves contrast of Link when in hover state dequelabs/cauldron
2 participants
@tbusillo @Keerthi-Penukonda