Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page title is not updated when navigating directly to a component page #816

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

nikolaps17
Copy link
Contributor

Fixed #787

@nikolaps17 nikolaps17 requested a review from a team as a code owner October 21, 2022 14:18
@abbeyperini-deque
Copy link
Contributor

Love this solution!

Only thing is it's currently overriding the dynamic description.

@nikolaps17
Copy link
Contributor Author

Sorry, my bad. I didn't notice. I'm going to fix it.

@nikolaps17
Copy link
Contributor Author

@abbeyperini-deque That should do it.

@abbeyperini-deque
Copy link
Contributor

🚨 reviewed for security 🚨

@abbeyperini-deque
Copy link
Contributor

Screen.Recording.2022-10-21.at.1.59.21.PM.mov

Copy link
Contributor

@abbeyperini-deque abbeyperini-deque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lovely refactor! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page title is not updated when navigating directly to a component page
3 participants