Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): ensure that Dialog and Toast components cleanup on unmount #1003

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(react): ensure that Dialog and Toast components cleanup on unmount #1003

merged 1 commit into from
Mar 30, 2023

Conversation

scurker
Copy link
Member

@scurker scurker commented Mar 30, 2023

closes #1001

@scurker scurker requested a review from a team as a code owner March 30, 2023 18:26
@github-actions
Copy link
Contributor

Preview branch generated at https://cleanup-aria-isolate.d1gko6en628vir.amplifyapp.com

@scurker scurker merged commit 07163da into develop Mar 30, 2023
@scurker scurker deleted the cleanup-aria-isolate branch March 30, 2023 19:02
@github-actions
Copy link
Contributor

Preview branch generated at https://cleanup-aria-isolate.d1gko6en628vir.amplifyapp.com

This was referenced Apr 4, 2023
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schne324 schne324 schne324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmounting Dialog/Toast elements can create accessibility issues
2 participants
@scurker @schne324