From b9b419a2937b5b475973d51e104b092910ed51cb Mon Sep 17 00:00:00 2001 From: Wilco Fiers Date: Mon, 23 Jan 2023 18:00:08 +0100 Subject: [PATCH] chore(iconLigature): comment on possible false positive --- lib/commons/text/is-icon-ligature.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/commons/text/is-icon-ligature.js b/lib/commons/text/is-icon-ligature.js index 6a01cbd645..01e97fab68 100644 --- a/lib/commons/text/is-icon-ligature.js +++ b/lib/commons/text/is-icon-ligature.js @@ -107,8 +107,9 @@ function isIconLigature( } const font = fonts[fontFamily]; - // improve the performance by only comparing the image data of a font - // a certain number of times + // improve the performance by only comparing the image data of a fon a certain number of times + // NOTE: This MIGHT cause an issue if someone uses an icon font to render actual text. + // We're leaving this as-is, unless someone reports a false positive over it. if (font.occurrences >= occurrenceThreshold) { // if the font has always been a ligature assume it's a ligature font if (font.numLigatures / font.occurrences === 1) {