From e235e9075d554fc2a63c10a4a66707a291e43019 Mon Sep 17 00:00:00 2001
From: eps1lon <silbermann.sebastian@gmail.com>
Date: Wed, 28 Oct 2020 22:41:02 +0100
Subject: [PATCH 1/5] feat: Add aria-dialog-name

---
 doc/rule-descriptions.md                      |  1 +
 lib/rules/aria-dialog-name.json               | 13 +++
 .../aria-dialog-name/aria-dialog-name.html    | 33 +++++++
 .../aria-dialog-name/aria-dialog-name.json    | 28 ++++++
 .../virtual-rules/aria-dialog-name.js         | 87 +++++++++++++++++++
 test/integration/virtual-rules/index.html     |  1 +
 6 files changed, 163 insertions(+)
 create mode 100644 lib/rules/aria-dialog-name.json
 create mode 100644 test/integration/rules/aria-dialog-name/aria-dialog-name.html
 create mode 100644 test/integration/rules/aria-dialog-name/aria-dialog-name.json
 create mode 100644 test/integration/virtual-rules/aria-dialog-name.js

diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md
index 29786f47cc..b6eb304786 100644
--- a/doc/rule-descriptions.md
+++ b/doc/rule-descriptions.md
@@ -15,6 +15,7 @@
 | [area-alt](https://dequeuniversity.com/rules/axe/4.0/area-alt?application=RuleDescription)                                       | Ensures &lt;area&gt; elements of image maps have alternate text                                               | Critical          | cat.text-alternatives, wcag2a, wcag111, wcag244, wcag412, section508, section508.22.a | failure, needs&nbsp;review |
 | [aria-allowed-attr](https://dequeuniversity.com/rules/axe/4.0/aria-allowed-attr?application=RuleDescription)                     | Ensures ARIA attributes are allowed for an element&apos;s role                                                | Critical          | cat.aria, wcag2a, wcag412                                                             | failure                    |
 | [aria-command-name](https://dequeuniversity.com/rules/axe/4.0/aria-command-name?application=RuleDescription)                     | Ensures every ARIA button, link and menuitem has an accessible name                                           | Serious           | wcag2a, wcag412                                                                       | failure, needs&nbsp;review |
+| [aria-dialog-name](https://dequeuniversity.com/rules/axe/4.0/aria-dialog-name?application=RuleDescription)                       | Ensures every ARIA dialog and alertdialog node has an accessible name                                         | Serious           | cat.aria, wcag2a, wcag412                                                             | failure, needs&nbsp;review |
 | [aria-hidden-body](https://dequeuniversity.com/rules/axe/4.0/aria-hidden-body?application=RuleDescription)                       | Ensures aria-hidden=&apos;true&apos; is not present on the document body.                                     | Critical          | cat.aria, wcag2a, wcag412                                                             | failure                    |
 | [aria-hidden-focus](https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=RuleDescription)                     | Ensures aria-hidden elements do not contain focusable elements                                                | Serious           | cat.name-role-value, wcag2a, wcag412, wcag131                                         | failure, needs&nbsp;review |
 | [aria-input-field-name](https://dequeuniversity.com/rules/axe/4.0/aria-input-field-name?application=RuleDescription)             | Ensures every ARIA input field has an accessible name                                                         | Moderate, Serious | cat.aria, wcag2a, wcag412                                                             | failure, needs&nbsp;review |
diff --git a/lib/rules/aria-dialog-name.json b/lib/rules/aria-dialog-name.json
new file mode 100644
index 0000000000..4c6c8945f9
--- /dev/null
+++ b/lib/rules/aria-dialog-name.json
@@ -0,0 +1,13 @@
+{
+	"id": "aria-dialog-name",
+	"selector": "[role=\"dialog\"], [role=\"alertdialog\"]",
+	"matches": "no-naming-method-matches",
+	"tags": ["cat.aria", "wcag2a", "wcag412"],
+	"metadata": {
+		"description": "Ensures every ARIA dialog and alertdialog node has an accessible name",
+		"help": "ARIA dialog and alertdialog nodes must have an accessible name"
+	},
+	"all": [],
+	"any": ["aria-label", "aria-labelledby", "non-empty-title"],
+	"none": []
+}
diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.html b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
new file mode 100644
index 0000000000..e18c0fa107
--- /dev/null
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
@@ -0,0 +1,33 @@
+<!-- PASS -->
+<dialog id="pass1" aria-label="Cookies" />
+<dialog id="pass2" title="Cookies" />
+<dialog id="pass3" aria-labelledby="dialog-heading">
+	<h2>Cookies</h2>
+</dialog>
+<div id="pass4" role="dialog" aria-label="Cookies" />
+<div id="pass5" role="dialog" title="Cookies" />
+<div id="pass6" role="dialog" aria-labelledby="dialog-div-heading">
+	<h2>Cookies</h2>
+</div>
+<dialog id="pass7" role="alertdialog" aria-label="Cookies" />
+<dialog id="pass8" role="alertdialog" title="Cookies" />
+<dialog id="pass9" role="alertdialog" aria-labelledby="alertdialog-heading">
+	<h2>Cookies</h2>
+</dialog>
+<div id="pass10" role="alertdialog" aria-label="Cookies" />
+<div id="pass11" role="alertdialog" title="Cookies" />
+<div id="pass12" role="alertdialog" aria-labelledby="alertdialog-div-heading">
+	<h2>Cookies</h2>
+</div>
+
+<div id="print">print file</div>
+
+<!-- FAIL -->
+<dialog id="fail1" />
+<dialog id="fail2" aria-labelledby="non-existent" />
+<div id="fail3" role="dialog" />
+<div id="fail4" role="dialog" aria-labelledby="non-existent" />
+<dialog id="fail5" role="alertdialog" />
+<dialog id="fail6" role="alertdialog" aria-labelledby="non-existent" />
+<div id="fail7" role="alertdialog" />
+<div id="fail8" role="alertdialog" aria-labelledby="non-existent" />
diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.json b/test/integration/rules/aria-dialog-name/aria-dialog-name.json
new file mode 100644
index 0000000000..d361ae1096
--- /dev/null
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.json
@@ -0,0 +1,28 @@
+{
+	"description": "aria-dialog-name test",
+	"rule": "aria-dialog-name",
+	"passes": [
+		["#pass1"],
+		["#pass2"],
+		["#pass3"],
+		["#pass4"],
+		["#pass5"],
+		["#pass6"],
+		["#pass7"],
+		["#pass8"],
+		["#pass9"],
+		["#pass10"],
+		["#pass11"],
+		["#pass12"]
+	],
+	"violations": [
+		["#fail1"],
+		["#fail2"],
+		["#fail3"],
+		["#fail4"],
+		["#fail5"],
+		["#fail6"],
+		["#fail7"],
+		["#fail8"]
+	]
+}
diff --git a/test/integration/virtual-rules/aria-dialog-name.js b/test/integration/virtual-rules/aria-dialog-name.js
new file mode 100644
index 0000000000..fad44cc1b8
--- /dev/null
+++ b/test/integration/virtual-rules/aria-dialog-name.js
@@ -0,0 +1,87 @@
+describe('aria-dialog-name', function() {
+	it('should pass for aria-label', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'dialog',
+			attributes: {
+				'aria-label': 'foobar'
+			}
+		});
+		node.parent = null;
+
+		var results = axe.runVirtualRule('aria-dialog-name', node);
+
+		assert.lengthOf(results.passes, 1);
+		assert.lengthOf(results.violations, 0);
+		assert.lengthOf(results.incomplete, 0);
+	});
+
+	it('should incomplete for aria-labelledby', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'div',
+			attributes: {
+				'role': 'dialog',
+				'aria-labelledby': 'foobar'
+			}
+		});
+		node.parent = null;
+
+		var results = axe.runVirtualRule('aria-dialog-name', node);
+
+		assert.lengthOf(results.passes, 0);
+		assert.lengthOf(results.violations, 0);
+		assert.lengthOf(results.incomplete, 1);
+	});
+
+	it('should pass for title', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'dialog',
+			attributes: {
+				role: 'alertdialog',
+				title: 'foobar'
+			}
+		});
+		// children are required since titleText comes after subtree text
+		// in accessible name calculation
+		node.children = [];
+		node.parent = null;
+
+		var results = axe.runVirtualRule('aria-dialog-name', node);
+
+		assert.lengthOf(results.passes, 1);
+		assert.lengthOf(results.violations, 0);
+		assert.lengthOf(results.incomplete, 0);
+	});
+
+	it('should fail when aria-label contains only whitespace', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'div',
+			attributes: {
+				role: 'alertdialog',
+				'aria-label': ' \t   \n   '
+			}
+		});
+		node.children = [];
+
+		var results = axe.runVirtualRule('aria-dialog-name', node);
+
+		assert.lengthOf(results.passes, 0);
+		assert.lengthOf(results.violations, 1);
+		assert.lengthOf(results.incomplete, 0);
+	});
+
+	it('should fail when title is empty', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'dialog',
+			attributes: {
+				title: ''
+			}
+		});
+		node.children = [];
+
+		var results = axe.runVirtualRule('aria-dialog-name', node);
+
+		assert.lengthOf(results.passes, 0);
+		assert.lengthOf(results.violations, 1);
+		assert.lengthOf(results.incomplete, 0);
+	});
+});
diff --git a/test/integration/virtual-rules/index.html b/test/integration/virtual-rules/index.html
index 4fe25f4bd5..4fbddbc3bd 100644
--- a/test/integration/virtual-rules/index.html
+++ b/test/integration/virtual-rules/index.html
@@ -23,6 +23,7 @@
 		<div id="mocha"></div>
 		<script src="area-alt.js"></script>
 		<script src="aria-command-name.js"></script>
+		<script src="aria-dialog-name.js"></script>
 		<script src="aria-input-field-name.js"></script>
 		<script src="aria-progressbar-name.js"></script>
 		<script src="aria-toggle-field-name.js"></script>

From ec69185a4666216d7a942be50b7ab251e7249cb8 Mon Sep 17 00:00:00 2001
From: eps1lon <silbermann.sebastian@gmail.com>
Date: Wed, 28 Oct 2020 23:07:41 +0100
Subject: [PATCH 2/5] fix: no self closing and add heading ids

---
 .../aria-dialog-name/aria-dialog-name.html    | 42 +++++++++----------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.html b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
index e18c0fa107..211dde63c9 100644
--- a/test/integration/rules/aria-dialog-name/aria-dialog-name.html
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
@@ -1,33 +1,31 @@
 <!-- PASS -->
-<dialog id="pass1" aria-label="Cookies" />
-<dialog id="pass2" title="Cookies" />
+<dialog id="pass1" aria-label="Cookies"></dialog>
+<dialog id="pass2" title="Cookies"></dialog>
 <dialog id="pass3" aria-labelledby="dialog-heading">
-	<h2>Cookies</h2>
+	<h2 id="dialog-heading">Cookies</h2>
 </dialog>
-<div id="pass4" role="dialog" aria-label="Cookies" />
-<div id="pass5" role="dialog" title="Cookies" />
+<div id="pass4" role="dialog" aria-label="Cookies"></div>
+<div id="pass5" role="dialog" title="Cookies"></div>
 <div id="pass6" role="dialog" aria-labelledby="dialog-div-heading">
-	<h2>Cookies</h2>
+	<h2 id="dialog-div-heading">Cookies</h2>
 </div>
-<dialog id="pass7" role="alertdialog" aria-label="Cookies" />
-<dialog id="pass8" role="alertdialog" title="Cookies" />
+<dialog id="pass7" role="alertdialog" aria-label="Cookies"></dialog>
+<dialog id="pass8" role="alertdialog" title="Cookies"></dialog>
 <dialog id="pass9" role="alertdialog" aria-labelledby="alertdialog-heading">
-	<h2>Cookies</h2>
+	<h2 id="alertdialog-heading">Cookies</h2>
 </dialog>
-<div id="pass10" role="alertdialog" aria-label="Cookies" />
-<div id="pass11" role="alertdialog" title="Cookies" />
+<div id="pass10" role="alertdialog" aria-label="Cookies"></div>
+<div id="pass11" role="alertdialog" title="Cookies"></div>
 <div id="pass12" role="alertdialog" aria-labelledby="alertdialog-div-heading">
-	<h2>Cookies</h2>
+	<h2 id="alertdialog-div-heading">Cookies</h2>
 </div>
 
-<div id="print">print file</div>
-
 <!-- FAIL -->
-<dialog id="fail1" />
-<dialog id="fail2" aria-labelledby="non-existent" />
-<div id="fail3" role="dialog" />
-<div id="fail4" role="dialog" aria-labelledby="non-existent" />
-<dialog id="fail5" role="alertdialog" />
-<dialog id="fail6" role="alertdialog" aria-labelledby="non-existent" />
-<div id="fail7" role="alertdialog" />
-<div id="fail8" role="alertdialog" aria-labelledby="non-existent" />
+<dialog id="fail1"></dialog>
+<dialog id="fail2" aria-labelledby="non-existent"></dialog>
+<div id="fail3" role="dialog"></div>
+<div id="fail4" role="dialog" aria-labelledby="non-existent"></div>
+<dialog id="fail5" role="alertdialog"></dialog>
+<dialog id="fail6" role="alertdialog" aria-labelledby="non-existent"></dialog>
+<div id="fail7" role="alertdialog"></div>
+<div id="fail8" role="alertdialog" aria-labelledby="non-existent"></div>

From 8d8d14e3c91376038a6ee1c90ba50eac794c0dfc Mon Sep 17 00:00:00 2001
From: eps1lon <silbermann.sebastian@gmail.com>
Date: Wed, 28 Oct 2020 23:28:07 +0100
Subject: [PATCH 3/5] Remove implicit dialogs

---
 .../aria-dialog-name/aria-dialog-name.html    | 37 ++++++++-----------
 .../aria-dialog-name/aria-dialog-name.json    |  9 +----
 .../virtual-rules/aria-dialog-name.js         | 10 +++--
 3 files changed, 23 insertions(+), 33 deletions(-)

diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.html b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
index 211dde63c9..e4ed92b0a4 100644
--- a/test/integration/rules/aria-dialog-name/aria-dialog-name.html
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
@@ -1,31 +1,24 @@
 <!-- PASS -->
-<dialog id="pass1" aria-label="Cookies"></dialog>
-<dialog id="pass2" title="Cookies"></dialog>
-<dialog id="pass3" aria-labelledby="dialog-heading">
-	<h2 id="dialog-heading">Cookies</h2>
-</dialog>
-<div id="pass4" role="dialog" aria-label="Cookies"></div>
-<div id="pass5" role="dialog" title="Cookies"></div>
-<div id="pass6" role="dialog" aria-labelledby="dialog-div-heading">
+<div id="pass1" role="dialog" aria-label="Cookies"></div>
+<div id="pass2" role="dialog" title="Cookies"></div>
+<div id="pass3" role="dialog" aria-labelledby="dialog-div-heading">
 	<h2 id="dialog-div-heading">Cookies</h2>
 </div>
-<dialog id="pass7" role="alertdialog" aria-label="Cookies"></dialog>
-<dialog id="pass8" role="alertdialog" title="Cookies"></dialog>
-<dialog id="pass9" role="alertdialog" aria-labelledby="alertdialog-heading">
+<dialog id="pass4" role="alertdialog" aria-label="Cookies"></dialog>
+<dialog id="pass5" role="alertdialog" title="Cookies"></dialog>
+<dialog id="pass6" role="alertdialog" aria-labelledby="alertdialog-heading">
 	<h2 id="alertdialog-heading">Cookies</h2>
 </dialog>
-<div id="pass10" role="alertdialog" aria-label="Cookies"></div>
-<div id="pass11" role="alertdialog" title="Cookies"></div>
-<div id="pass12" role="alertdialog" aria-labelledby="alertdialog-div-heading">
+<div id="pass7" role="alertdialog" aria-label="Cookies"></div>
+<div id="pass8" role="alertdialog" title="Cookies"></div>
+<div id="pass9" role="alertdialog" aria-labelledby="alertdialog-div-heading">
 	<h2 id="alertdialog-div-heading">Cookies</h2>
 </div>
 
 <!-- FAIL -->
-<dialog id="fail1"></dialog>
-<dialog id="fail2" aria-labelledby="non-existent"></dialog>
-<div id="fail3" role="dialog"></div>
-<div id="fail4" role="dialog" aria-labelledby="non-existent"></div>
-<dialog id="fail5" role="alertdialog"></dialog>
-<dialog id="fail6" role="alertdialog" aria-labelledby="non-existent"></dialog>
-<div id="fail7" role="alertdialog"></div>
-<div id="fail8" role="alertdialog" aria-labelledby="non-existent"></div>
+<div id="fail1" role="dialog"></div>
+<div id="fail2" role="dialog" aria-labelledby="non-existent"></div>
+<dialog id="fail3" role="alertdialog"></dialog>
+<dialog id="fail4" role="alertdialog" aria-labelledby="non-existent"></dialog>
+<div id="fail5" role="alertdialog"></div>
+<div id="fail6" role="alertdialog" aria-labelledby="non-existent"></div>
diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.json b/test/integration/rules/aria-dialog-name/aria-dialog-name.json
index d361ae1096..bcf6978808 100644
--- a/test/integration/rules/aria-dialog-name/aria-dialog-name.json
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.json
@@ -10,10 +10,7 @@
 		["#pass6"],
 		["#pass7"],
 		["#pass8"],
-		["#pass9"],
-		["#pass10"],
-		["#pass11"],
-		["#pass12"]
+		["#pass9"]
 	],
 	"violations": [
 		["#fail1"],
@@ -21,8 +18,6 @@
 		["#fail3"],
 		["#fail4"],
 		["#fail5"],
-		["#fail6"],
-		["#fail7"],
-		["#fail8"]
+		["#fail6"]
 	]
 }
diff --git a/test/integration/virtual-rules/aria-dialog-name.js b/test/integration/virtual-rules/aria-dialog-name.js
index fad44cc1b8..4892f9d9e3 100644
--- a/test/integration/virtual-rules/aria-dialog-name.js
+++ b/test/integration/virtual-rules/aria-dialog-name.js
@@ -1,8 +1,9 @@
 describe('aria-dialog-name', function() {
 	it('should pass for aria-label', function() {
 		var node = new axe.SerialVirtualNode({
-			nodeName: 'dialog',
+			nodeName: 'div',
 			attributes: {
+				role: 'dialog',
 				'aria-label': 'foobar'
 			}
 		});
@@ -19,7 +20,7 @@ describe('aria-dialog-name', function() {
 		var node = new axe.SerialVirtualNode({
 			nodeName: 'div',
 			attributes: {
-				'role': 'dialog',
+				role: 'dialog',
 				'aria-labelledby': 'foobar'
 			}
 		});
@@ -34,7 +35,7 @@ describe('aria-dialog-name', function() {
 
 	it('should pass for title', function() {
 		var node = new axe.SerialVirtualNode({
-			nodeName: 'dialog',
+			nodeName: 'div',
 			attributes: {
 				role: 'alertdialog',
 				title: 'foobar'
@@ -71,8 +72,9 @@ describe('aria-dialog-name', function() {
 
 	it('should fail when title is empty', function() {
 		var node = new axe.SerialVirtualNode({
-			nodeName: 'dialog',
+			nodeName: 'div',
 			attributes: {
+				role: 'dialog',
 				title: ''
 			}
 		});

From 66bfc7984837ed8733dd4adf4369b4ba947a1e1d Mon Sep 17 00:00:00 2001
From: eps1lon <silbermann.sebastian@gmail.com>
Date: Wed, 28 Oct 2020 23:50:58 +0100
Subject: [PATCH 4/5] Include <dialog> in tests

---
 .../rules/aria-dialog-name/aria-dialog-name.html       | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/integration/rules/aria-dialog-name/aria-dialog-name.html b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
index e4ed92b0a4..56e8471d78 100644
--- a/test/integration/rules/aria-dialog-name/aria-dialog-name.html
+++ b/test/integration/rules/aria-dialog-name/aria-dialog-name.html
@@ -4,9 +4,9 @@
 <div id="pass3" role="dialog" aria-labelledby="dialog-div-heading">
 	<h2 id="dialog-div-heading">Cookies</h2>
 </div>
-<dialog id="pass4" role="alertdialog" aria-label="Cookies"></dialog>
-<dialog id="pass5" role="alertdialog" title="Cookies"></dialog>
-<dialog id="pass6" role="alertdialog" aria-labelledby="alertdialog-heading">
+<dialog id="pass4" open role="alertdialog" aria-label="Cookies"></dialog>
+<dialog id="pass5" open role="alertdialog" title="Cookies"></dialog>
+<dialog id="pass6" open role="alertdialog" aria-labelledby="alertdialog-heading">
 	<h2 id="alertdialog-heading">Cookies</h2>
 </dialog>
 <div id="pass7" role="alertdialog" aria-label="Cookies"></div>
@@ -18,7 +18,7 @@ <h2 id="alertdialog-div-heading">Cookies</h2>
 <!-- FAIL -->
 <div id="fail1" role="dialog"></div>
 <div id="fail2" role="dialog" aria-labelledby="non-existent"></div>
-<dialog id="fail3" role="alertdialog"></dialog>
-<dialog id="fail4" role="alertdialog" aria-labelledby="non-existent"></dialog>
+<dialog id="fail3" open role="alertdialog"></dialog>
+<dialog id="fail4" open role="alertdialog" aria-labelledby="non-existent"></dialog>
 <div id="fail5" role="alertdialog"></div>
 <div id="fail6" role="alertdialog" aria-labelledby="non-existent"></div>

From 4a8e59793834c2f11d78311c2bb71cdc8c1af0b5 Mon Sep 17 00:00:00 2001
From: eps1lon <silbermann.sebastian@gmail.com>
Date: Fri, 30 Oct 2020 12:06:16 +0100
Subject: [PATCH 5/5] Use best-practice instead

---
 doc/rule-descriptions.md        | 2 +-
 lib/rules/aria-dialog-name.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md
index b124825c4c..6586464ef9 100644
--- a/doc/rule-descriptions.md
+++ b/doc/rule-descriptions.md
@@ -15,7 +15,7 @@
 | [area-alt](https://dequeuniversity.com/rules/axe/4.0/area-alt?application=RuleDescription)                                       | Ensures &lt;area&gt; elements of image maps have alternate text                                               | Critical          | cat.text-alternatives, wcag2a, wcag111, wcag244, wcag412, section508, section508.22.a | failure, needs&nbsp;review |
 | [aria-allowed-attr](https://dequeuniversity.com/rules/axe/4.0/aria-allowed-attr?application=RuleDescription)                     | Ensures ARIA attributes are allowed for an element&apos;s role                                                | Critical          | cat.aria, wcag2a, wcag412                                                             | failure                    |
 | [aria-command-name](https://dequeuniversity.com/rules/axe/4.0/aria-command-name?application=RuleDescription)                     | Ensures every ARIA button, link and menuitem has an accessible name                                           | Serious           | cat.aria, wcag2a, wcag412                                                             | failure, needs&nbsp;review |
-| [aria-dialog-name](https://dequeuniversity.com/rules/axe/4.0/aria-dialog-name?application=RuleDescription)                       | Ensures every ARIA dialog and alertdialog node has an accessible name                                         | Serious           | cat.aria, wcag2a, wcag412                                                             | failure, needs&nbsp;review |
+| [aria-dialog-name](https://dequeuniversity.com/rules/axe/4.0/aria-dialog-name?application=RuleDescription)                       | Ensures every ARIA dialog and alertdialog node has an accessible name                                         | Serious           | cat.aria, best-practice                                                       | failure, needs&nbsp;review |
 | [aria-hidden-body](https://dequeuniversity.com/rules/axe/4.0/aria-hidden-body?application=RuleDescription)                       | Ensures aria-hidden=&apos;true&apos; is not present on the document body.                                     | Critical          | cat.aria, wcag2a, wcag412                                                             | failure                    |
 | [aria-hidden-focus](https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=RuleDescription)                     | Ensures aria-hidden elements do not contain focusable elements                                                | Serious           | cat.name-role-value, wcag2a, wcag412, wcag131                                         | failure, needs&nbsp;review |
 | [aria-input-field-name](https://dequeuniversity.com/rules/axe/4.0/aria-input-field-name?application=RuleDescription)             | Ensures every ARIA input field has an accessible name                                                         | Moderate, Serious | cat.aria, wcag2a, wcag412                                                             | failure, needs&nbsp;review |
diff --git a/lib/rules/aria-dialog-name.json b/lib/rules/aria-dialog-name.json
index 4c6c8945f9..ab1e882982 100644
--- a/lib/rules/aria-dialog-name.json
+++ b/lib/rules/aria-dialog-name.json
@@ -2,7 +2,7 @@
 	"id": "aria-dialog-name",
 	"selector": "[role=\"dialog\"], [role=\"alertdialog\"]",
 	"matches": "no-naming-method-matches",
-	"tags": ["cat.aria", "wcag2a", "wcag412"],
+	"tags": ["cat.aria", "best-practice"],
 	"metadata": {
 		"description": "Ensures every ARIA dialog and alertdialog node has an accessible name",
 		"help": "ARIA dialog and alertdialog nodes must have an accessible name"