Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axe.d.ts): correct Check.evaluate and Check.after types #976

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

stephenmathieson
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

Description of the changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

These types may either be a string or a function.

These types may either be a string or a function.

Closes #974
Copy link
Contributor

@jeeyyy jeeyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Build pending. Looks good.

@stephenmathieson
Copy link
Member Author

Build appears to be failing due to a CircleCI/npm outage.

@WilcoFiers WilcoFiers merged commit db3ed40 into develop Jun 28, 2018
@WilcoFiers WilcoFiers deleted the fix-check-eval-type branch June 28, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect typings for Check.evaluate and Check.after
3 participants