fix: Right trim URLs before outputting them in getSelector #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
reviewed
May 28, 2018
| @@ -19,6 +19,10 @@ function splitString (str, splitIndex) { | |||
| return [str.substring(0, splitIndex), str.substring(splitIndex)]; | |||
| } | |||
|
|
|||
| function trimRight (str) { | |||
There was a problem hiding this comment.
Use prototype methods - .trimRight() or .trimEnd()?
Need IE Support?
There was a problem hiding this comment.
yeah, needs to work in IE.
jeeyyy
approved these changes
May 28, 2018
WilcoFiers
force-pushed
the
friendly-url-trim
branch
2 times, most recently
from
88cb1dd
to
a416d06
Compare
dylanb
approved these changes
May 29, 2018
WilcoFiers
force-pushed
the
friendly-url-trim
branch
from
a416d06
to
08f0cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #788
PR Checklist
Please check if your PR fulfills the following requirements:
Description of the changes
Does this PR introduce a breaking change?
Other information