headings rules: Skip headings with a role change #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
reviewed
Feb 8, 2018
| let explicitRoles; | ||
| if (node.hasAttribute('role')) { | ||
| explicitRoles = node.getAttribute('role').split(/\s+/i) | ||
| .filter(axe.commons.aria.isValidRole); |
There was a problem hiding this comment.
The splitting and filtering here seems like a utility we could reuse.
There was a problem hiding this comment.
Seems pretty trivial. I would like us to at some point move towards a stronger getRoles() method, but I think that needs a little more thought, and we should probably have a better idea of how we do accessibility support before we can.
| it('should return true on regular headings without roles', function () { | ||
| var h1 = document.createElement('h1'); | ||
| var h2 = document.createElement('h2'); | ||
| var h3 = document.createElement('h3'); |
There was a problem hiding this comment.
Do these in-memory elements get cleaned up automatically by the test runner?
There was a problem hiding this comment.
No, but they do by the garbage collector.
This was referenced Feb 9, 2018
marcysutton
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #645