fix(rule): Remove coverage of svg[role="img"] for image-alt rule
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dylanb
reviewed
Jan 24, 2018
| @@ -16,3 +16,4 @@ | |||
| <img src="img.jpg" id="pass8" aria-labelledby="ninjamonkeys"> | |||
| <div role="img" alt="blah" id="violation6"></div> | |||
| <div role="img" aria-label="blah" id="pass9"></div> | |||
| <svg rol="img" id="ignore1"><title>SVG Title</title></svg> | |||
There was a problem hiding this comment.
There is a typo in the attribute
There was a problem hiding this comment.
Please fix the typo. I think you're right about excluding svg from this rule. We should have a separate SVG rule instead.
We have been advised that best practice is to use the following for inline SVGs: ``` <svg role="img"> <title>SVG Title</title> </svg> ``` which is echoed in [this article](https://css-tricks.com/accessible-svgs/#article-header-id-6). I see that there is conversation in this issue dequelabs#20 about how to best go about it, but for now the test for `svg[role="img"]` needs to be removed since it isn't really valid.
codingmatty
force-pushed
the
svg-img-no-alt
branch
from
6f41324 to
ea41048
Compare
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
…equelabs#683) The timeout was decreased in 6f5498e to 20 seconds (apparently accidentally since that commit was classfied as a refactor ... and it also didn't update the --help text accordingly). This commit changes it back to 90 seconds to match the --help text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been advised that best practice is to use the following for inline SVGs:
which is echoed in this article.
I see that there is conversation in this issue #20 about how to best go about it, but for now the test for
svg[role="img"]needs to be removed since it isn't really valid.