Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lookupTables through public API #616

Closed
marcysutton opened this issue Nov 15, 2017 · 4 comments
Closed

Expose lookupTables through public API #616

marcysutton opened this issue Nov 15, 2017 · 4 comments
Labels
docs Documentation changes support

Comments

@marcysutton
Copy link
Contributor

marcysutton commented Nov 15, 2017

As part of our ongoing Support agreement, we had a request to expose the ARIA lookupTables through the public axe-core API. These are pretty stable, so I don't anticipate much work in the way of maintaining backwards compatibility.

I believe the goal is to expose the roles, attributes, and global attributes inside of rules and checks.

https://github.com/dequelabs/axe-core/blob/develop/lib/commons/aria/index.js

@marcysutton
Copy link
Contributor Author

These are available through the global axe object:

axe.commons.aria._lut

Should we alias this when we document it?

@WilcoFiers
Copy link
Contributor

We can simply rename it. I think axe.commons.aria.lookupTable would be fine. We're not accessing it directly in any of our checks or commons.

@dylanb
Copy link
Contributor

dylanb commented Nov 23, 2017

What are the uses/use cases for use of this table? Might be better to expose those use cases as functions so we can change the implementation of the ARIA data in a backwards compatible way.

@marcysutton
Copy link
Contributor Author

I've asked for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes support
Projects
None yet
Development

No branches or pull requests

3 participants