fix(get-ancestry): don't error when there is no parent #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
previously approved these changes
Oct 17, 2024
dbjorge
approved these changes
Oct 17, 2024
| @@ -9,7 +9,7 @@ function generateAncestry(node) { | |||
| if ( | |||
| nodeName !== 'head' && | |||
| nodeName !== 'body' && | |||
| parentNode.children.length > 1 | |||
| parentNode?.children.length > 1 | |||
There was a problem hiding this comment.
I didn't realize that the optional chaining operation short circuited like this; I got worried that this would need to be parentNode?.children?.length, but it turns out this is fine
straker
added a commit
that referenced
this pull request
Oct 21, 2024
Seems I removed the conditional check on the children lookup during a refactor. Adding it back in and ensuring there's a test so this doesn't happen again.
Merged
WilcoFiers
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems I removed the conditional check on the children lookup during a refactor. Adding it back in and ensuring there's a test so this doesn't happen again.