Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growl security vulnerability #412

Closed
marcysutton opened this issue Jul 7, 2017 · 1 comment
Closed

Growl security vulnerability #412

marcysutton opened this issue Jul 7, 2017 · 1 comment
Labels
core Issues in the core code (lib/core)

Comments

@marcysutton
Copy link
Contributor

marcysutton commented Jul 7, 2017

Our build broke due to a security vulnerability in Growl, found by retire.js.

Growl is included in many major libraries, including Mocha. I added a commit to ignore Mocha in retire.js, but to get our build to run I also had to disable Growl, which means it's being included by another dependency (possibly Babel, but I don't see it in their package.json).

We should remove the ignore setting for Growl as soon as the vulnerability is fixed, unless we determine it only impacts testing and therefore has a lower risk. The vuln can be monitored at https://nodesecurity.io/advisories/146.

@marcysutton
Copy link
Contributor Author

It looks like this was fixed–there's a new version of 1.10.2. tj/node-growl@d71177d

But–there's a thread by the Mocha team on updating it, without a resolution (yet). We can follow that here: mochajs/mocha#2930

@WilcoFiers WilcoFiers added the core Issues in the core code (lib/core) label Apr 17, 2018
@WilcoFiers WilcoFiers added this to the Q2 2018 update milestone Apr 17, 2018
@WilcoFiers WilcoFiers removed this from the Q2 2018 update milestone Apr 23, 2019
@straker straker mentioned this issue Nov 20, 2019
2 tasks
@straker straker closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core)
Projects
None yet
Development

No branches or pull requests

3 participants