Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The aria-required-children rules should provide related nodes #4032

Closed
WilcoFiers opened this issue May 23, 2023 · 0 comments · Fixed by #4033
Closed

The aria-required-children rules should provide related nodes #4032

WilcoFiers opened this issue May 23, 2023 · 0 comments · Fixed by #4033
Labels
core Issues in the core code (lib/core) fix Bug fixes

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 23, 2023 •
edited by padmavemulapati
Loading

When we set relatedNodes in aria-required-children-evaluate, we're passing vNodes, not DOM nodes. Axe-core ignores those and so we wend up without related nodes. We should put something in place to prevent this from happening. I'll see if we can just allow vNodes as relatedNodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core) fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aria-required-children): set related nodes for invalid children dequelabs/axe-core
1 participant
@WilcoFiers