chore: Refactor createStackingOrder #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
approved these changes
Mar 6, 2023
straker
added a commit
that referenced
this pull request
Mar 15, 2023
…acking contexts (#3930) * fix(create-grid): correctly compute stack order for non-positioned stacking contexts * chore: Refactor createStackingOrder (#3932) * chore: Refactor createStackingOrder * Remove magic numbers * use treewalker nodeIndex * no floatpoint precision errors * pass nodeIndex to createGrid for shadowDom * do it properly * remove whitespace * test for outside tree elements --------- Co-authored-by: Wilco Fiers <[email protected]>
straker
added a commit
that referenced
this pull request
Mar 22, 2023
…with opacity (#3944) * fix(create-grid): correctly compute stack order for non-positioned stacking contexts * chore: Refactor createStackingOrder (#3932) * chore: Refactor createStackingOrder * Remove magic numbers * use treewalker nodeIndex * no floatpoint precision errors * pass nodeIndex to createGrid for shadowDom * do it properly * remove whitespace * fix(color-contrast): correctly handle opacity on parent elements * working * idea finalized * remove comments * move function * tests! * fix comments * fix stuff --------- Co-authored-by: Wilco Fiers <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my review of #3930 I ended up refactoring that method. I couldn't wrap my brain around how it worked.