Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-required-children should map to ACT rule ARIA required context role (ff89c9) #3789

Closed
WilcoFiers opened this issue Nov 18, 2022 · 1 comment · Fixed by #3790
Closed
Labels
ACT Rules rule metadata Issues in the rule metadata code (lib/rules)

Comments

@WilcoFiers
Copy link
Contributor

In order to avoid duplicate issues, axe-core's aria-required-parent rule does not fail the following, and leaves the testing of this up to aria-required-children.

<div role="list">
  <div aria-live="polite">
    <div role="listitem">item</div>
  </div>
</div>

To ensure correct mapping with ACT though, we need to add ARIA required context role (ff89c9) to the aria-required-children rule.

@padmavemulapati
Copy link

Validated with the 'axe-core' develop branch code base,
test snippet:

<div role="list">
  <div aria-live="polite">
    <div role="listitem">item</div>
  </div>
</div>

aria-required-parent is not failing for the test script, but failing for aria-required-children

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants