Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link-in-text-block not experimental #3648

Closed
WilcoFiers opened this issue Sep 7, 2022 · 1 comment
Closed

Make link-in-text-block not experimental #3648

WilcoFiers opened this issue Sep 7, 2022 · 1 comment
Assignees
@WilcoFiers
Labels
pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Milestone
Axe-core 4.5

Comments

@WilcoFiers
Copy link
Contributor

The link-in-text-block rule has been experimental for a good while. It has been sufficiently tested that I feel we can enable it by default. For this PR, we just need to remove the tag from the rule.
@WilcoFiers WilcoFiers added rules Issue or false result from an axe-core rule rule metadata Issues in the rule metadata code (lib/rules) labels Sep 7, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone Sep 7, 2022
@WilcoFiers WilcoFiers self-assigned this Oct 8, 2022
@WilcoFiers WilcoFiers mentioned this issue Oct 8, 2022
Merged
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Oct 8, 2022
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base,
Test script:

<a style=\"text-decoration: none; color: blue\" href=\"#\" id=\"fail-insufficient-text-contrast\">\n    Link text</a>
<a style=\"text-decoration: none; color: black; background-color: pink\" href=\"#\" id=\"fail-insufficient-background-contrast\">\n    Link text</a>

link-in-text-block rule is not holding experimental tag now.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
Axe-core 4.5
Development

No branches or pull requests
2 participants
@WilcoFiers @padmavemulapati