Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identical-links-same-purpose should be off by default #3611

Closed
WilcoFiers opened this issue Aug 17, 2022 · 1 comment
Closed

identical-links-same-purpose should be off by default #3611

WilcoFiers opened this issue Aug 17, 2022 · 1 comment
Assignees
Labels
feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)
Milestone

Comments

@WilcoFiers
Copy link
Contributor

Product

axe-core

Feature Description

After discussion with the axe extension team we've decided that going forward, all AAA rules will be turned off by default. This means we'll need to turn identical-links-same-purpose off. All other AAA rules are already disabled.

@WilcoFiers WilcoFiers added feat New feature or enhancement ungroomed Ticket needs a maintainer to prioritize and label rule metadata Issues in the rule metadata code (lib/rules) and removed ungroomed Ticket needs a maintainer to prioritize and label labels Aug 17, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone Aug 17, 2022
@WilcoFiers WilcoFiers self-assigned this Aug 18, 2022
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Aug 18, 2022
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code-base,
with the test script having incomeplete results for identical-links-same-purpose rule (which is having wcag2aaa tag) is now disabled by default.
Able to see with the old version of axe-core(4.3.5)
test-script:

<!-- native links with different purpose -->
<a id="incomplete13" href="https://facebook.com">follow us</a>
<a id="incomplete13-identical1" href="https://instagram.com">follow us</a>

<!-- multiple native links with differnt URLS with same filename but different pathname -->
<a id="incomplete14" href="/test/integration/full/directory-one/foo.html">Incomplete 14</a>
<a id="incomplete14-identical1" href="foo.html">Incomplete 14</a>
<a id="incomplete14-identical2" href="../directory-two/foo.html">Incomplete 14</a>

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

No branches or pull requests

2 participants