Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-endnotes role no longer requires children to contain a specific role #3445

Closed
jmooring opened this issue Apr 29, 2022 · 4 comments
Closed
Labels
fix Bug fixes pr A pr has been created for the issue standards Issues in the ARIA standards objects (lib/standards)
Milestone

Comments

@jmooring
Copy link

Google Chrome Version 101.0.4951.41 (Official Build) (64-bit)
Lighthouse 9.5.0

This example from the ARIA 1.1 doc-endnotes specification::

<section role="doc-endnotes">
  <h2>Notes</h2>
  <ol>
      <li id="6baa07af">
        <p>Additional results of this study can be found at … </p>
      </li>
      <li id="7b2c0555">
        <p>…</p>
      </li>
  </ol>
</section>

Generates a false positive:

Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children.

@straker
Copy link
Contributor

straker commented May 2, 2022

Thanks for the issue. DPub 1.1 is still a W3C Working Draft, and 1.0 is the current recommended version. Since 1.0 requires a doc-endnotes to have a doc-endnote as a child we will still fail the provided example.

@WilcoFiers
Copy link
Contributor

True as that may be, I don't really think there's anything inaccessible about this. I think we can get ahead of the W3C on this.

@WilcoFiers WilcoFiers added fix Bug fixes standards Issues in the ARIA standards objects (lib/standards) labels May 3, 2022
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.5, Axe-core 4.6 May 17, 2022
@straker
Copy link
Contributor

straker commented Jul 25, 2022

Work completed in #3280

@straker straker added the pr A pr has been created for the issue label Jul 25, 2022
@padmavemulapati
Copy link

Not an issue, already validated in #2759

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue standards Issues in the ARIA standards objects (lib/standards)
Projects
None yet
Development

No branches or pull requests

5 participants